[patch] gdb.python tests, fix up paths

[patch] gdb.python tests, fix up paths

[Matt Rice]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

This fixes some issues with the paths,
i'm seeing these all as './gdb.python/' here.

2011-07-03  Matt Rice  <ratmice@gmail.com>

        * gdb.python/python.exp: Update filename paths.
        * gdb.python/py-symtab.exp: Ditto.

In addition to these, I'm getting another error I haven't been able to
figure out.
the logs are pretty silent on the subject, here is the only useful
info i've found...
py-objfile-script-gdb.py consistently disappears after running the testsuite.


$ ls testsuite/gdb.python/py-objfile-script-gdb.py
testsuite/gdb.python/py-objfile-script-gdb.py
$ make -C testsuite/ check-gdb.python 2>&1 | grep  py-objfile-script-gdb.py
$ ls testsuite/gdb.python/py-objfile-script-gdb.py ls: cannot access
testsuite/gdb.python/py-objfile-script-gdb.py: No such file or
directory
$ make -C testsuite/ check-gdb.python 2>&1 | grep  py-objfile-script-gdb.py
ERROR: remote_download to host of
./gdb.python/py-objfile-script-gdb.py to
gdb.python/py-objfile-script-gdb.py: cp: cannot stat
`./gdb.python/py-objfile-script-gdb.py': No such file or directory

[-- Attachment #2: foo.diff --]
[-- Type: application/octet-stream, Size: 3536 bytes --]

diff --git a/gdb/testsuite/gdb.python/py-symtab.exp b/gdb/testsuite/gdb.python/py-symtab.exp
index c52f5ef..ef35c5d 100644
--- a/gdb/testsuite/gdb.python/py-symtab.exp
+++ b/gdb/testsuite/gdb.python/py-symtab.exp
@@ -54,13 +54,13 @@ gdb_py_test_silent_cmd "python sal = frame.find_sal()" "Get block" 0
 gdb_py_test_silent_cmd "python symtab = sal.symtab" "Get block" 0
 
 # Test sal.
-gdb_test "python print sal.symtab" "gdb/testsuite/gdb.python/py-symbol.c.*" "Test symtab"
+gdb_test "python print sal.symtab" ".*gdb.python/py-symbol.c.*" "Test symtab"
 gdb_test "python print sal.pc" "${decimal}" "Test sal.pc"
 gdb_test "python print sal.line" "42" "Test sal.line"
 gdb_test "python print sal.is_valid()" "True" "Test sal.is_valid"
 
 # Test symbol table.
-gdb_test "python print symtab.filename" "testsuite/gdb.python/py-symbol.c.*" "Test symtab.filename"
+gdb_test "python print symtab.filename" ".*gdb.python/py-symbol.c.*" "Test symtab.filename"
 gdb_test "python print symtab.objfile" "<gdb.Objfile object at ${hex}>" "Test symtab.objfile"
 gdb_test "python print symtab.fullname()" "testsuite/gdb.python/py-symbol.c.*" "Test symtab.fullname"
 gdb_test "python print symtab.is_valid()" "True" "Test symtab.is_valid()"
diff --git a/gdb/testsuite/gdb.python/python.exp b/gdb/testsuite/gdb.python/python.exp
index a68dd24..e0deb63 100644
--- a/gdb/testsuite/gdb.python/python.exp
+++ b/gdb/testsuite/gdb.python/python.exp
@@ -153,14 +153,14 @@ gdb_py_test_silent_cmd "python symtab = gdb.decode_line()" "test decode_line cur
 gdb_test "python print len(symtab)" "2" "Test decode_line current location"
 gdb_test "python print symtab\[0\]" "None" "Test decode_line expression parse"
 gdb_test "python print len(symtab\[1\])" "1" "Test decode_line current location"
-gdb_test "python print symtab\[1\]\[0\].symtab" "gdb/testsuite/gdb.python/python.c.*" "Test decode_line current locationn filename"
+gdb_test "python print symtab\[1\]\[0\].symtab" ".*gdb.python/python.c.*" "Test decode_line current locationn filename"
 gdb_test "python print symtab\[1\]\[0\].line" "22" "Test decode_line current location line number"
 
 gdb_py_test_silent_cmd "python symtab = gdb.decode_line(\"python.c:26 if foo\")" "test decode_line python.c:26" 1
 gdb_test "python print len(symtab)" "2" "Test decode_line python.c:26 length"
 gdb_test "python print symtab\[0\]" "if foo" "Test decode_line expression parse"
 gdb_test "python print len(symtab\[1\])" "1" "Test decode_line python.c:26 length"
-gdb_test "python print symtab\[1\]\[0\].symtab" "gdb/testsuite/gdb.python/python.c.*" "Test decode_line python.c:26 filename"
+gdb_test "python print symtab\[1\]\[0\].symtab" ".*gdb.python/python.c.*" "Test decode_line python.c:26 filename"
 gdb_test "python print symtab\[1\]\[0\].line" "26" "Test decode_line python.c:26 line number"
 
 gdb_test "python gdb.decode_line(\"randomfunc\")" \
@@ -168,7 +168,7 @@ gdb_test "python gdb.decode_line(\"randomfunc\")" \
 gdb_py_test_silent_cmd "python symtab = gdb.decode_line(\"func1\")" "test decode_line func1()" 1
 gdb_test "python print len(symtab)" "2" "Test decode_line func1 length"
 gdb_test "python print len(symtab\[1\])" "1" "Test decode_line func1 length"
-gdb_test "python print symtab\[1\]\[0\].symtab" "gdb/testsuite/gdb.python/python-1.c.*" "Test decode_line func1 filename"
+gdb_test "python print symtab\[1\]\[0\].symtab" ".*gdb.python/python-1.c.*" "Test decode_line func1 filename"
 gdb_test "python print symtab\[1\]\[0\].line" "19" "Test decode_line func1 line number"
 
 # gdb.write

Re: [patch] gdb.python tests, fix up paths

[Phil Muldoon]

Matt Rice <ratmice@gmail.com> writes:

> This fixes some issues with the paths,
> i'm seeing these all as './gdb.python/' here.
>
> 2011-07-03  Matt Rice  <ratmice@gmail.com>
>
>         * gdb.python/python.exp: Update filename paths.
>         * gdb.python/py-symtab.exp: Ditto.

> diff --git a/gdb/testsuite/gdb.python/py-symtab.exp b/gdb/testsuite/gdb.python/py-symtab.exp
> index c52f5ef..ef35c5d 100644
> --- a/gdb/testsuite/gdb.python/py-symtab.exp
> +++ b/gdb/testsuite/gdb.python/py-symtab.exp
> @@ -54,13 +54,13 @@ gdb_py_test_silent_cmd "python sal = frame.find_sal()" "Get block" 0
> gdb_py_test_silent_cmd "python symtab = sal.symtab" "Get block" 0
>
> # Test sal.
> -gdb_test "python print sal.symtab" "gdb/testsuite/gdb.python/py-symbol.c.*" "Test symtab"
> +gdb_test "python print sal.symtab" ".*gdb.python/py-symbol.c.*" "Test symtab"

While this is okay, and right now reflects how we test, I am curious to
see what paths your testsuite instance is seeing.  Are you building
in-tree or out-of-tree (not that it matters beyond curiosity, the tests
should work regardless).  Needs a testsuite/ChangeLog too.


> In addition to these, I'm getting another error I haven't been able to
> figure out.
> the logs are pretty silent on the subject, here is the only useful
> info i've found...
> py-objfile-script-gdb.py consistently disappears after running the testsuite.


I can't test this right now due to the binutils bug you reported.  When
that is resolved, I will take a look.

Cheers

Phil

Re: [patch] gdb.python tests, fix up paths

[Matt Rice]

On Mon, Jul 4, 2011 at 3:09 AM, Phil Muldoon <pmuldoon@redhat.com> wrote:
> Matt Rice <ratmice@gmail.com> writes:
>
>> This fixes some issues with the paths,
>> i'm seeing these all as './gdb.python/' here.
>>
>> 2011-07-03  Matt Rice  <ratmice@gmail.com>
>>
>>         * gdb.python/python.exp: Update filename paths.
>>         * gdb.python/py-symtab.exp: Ditto.
>
>> diff --git a/gdb/testsuite/gdb.python/py-symtab.exp b/gdb/testsuite/gdb.python/py-symtab.exp
>> index c52f5ef..ef35c5d 100644
>> --- a/gdb/testsuite/gdb.python/py-symtab.exp
>> +++ b/gdb/testsuite/gdb.python/py-symtab.exp
>> @@ -54,13 +54,13 @@ gdb_py_test_silent_cmd "python sal = frame.find_sal()" "Get block" 0
>> gdb_py_test_silent_cmd "python symtab = sal.symtab" "Get block" 0
>>
>> # Test sal.
>> -gdb_test "python print sal.symtab" "gdb/testsuite/gdb.python/py-symbol.c.*" "Test symtab"
>> +gdb_test "python print sal.symtab" ".*gdb.python/py-symbol.c.*" "Test symtab"
>
> While this is okay, and right now reflects how we test, I am curious to
> see what paths your testsuite instance is seeing.

without the patch for easier grepping:

./gdb.python/py-symbol.c
(gdb) FAIL: gdb.python/py-symtab.exp: Test symtab
--
./gdb.python/py-symbol.c
(gdb) FAIL: gdb.python/py-symtab.exp: Test symtab.filename
--
./gdb.python/python.c
(gdb) FAIL: gdb.python/python.exp: Test decode_line current locationn filename
--
./gdb.python/python.c
(gdb) FAIL: gdb.python/python.exp: Test decode_line python.c:26 filename
--
./gdb.python/python-1.c
(gdb) FAIL: gdb.python/python.exp: Test decode_line func1 filename


 Are you building
> in-tree or out-of-tree (not that it matters beyond curiosity, the tests
> should work regardless).  Needs a testsuite/ChangeLog too.

building in-tree, guessing its probably
rm dest && cat src > dest but src == dest in the in-tree case.  Hadn't
thought about out-of-tree i'll give it a try.

ChangeLog entry was at the top of the email (not included in diff though).

>> In addition to these, I'm getting another error I haven't been able to
>> figure out.
>> the logs are pretty silent on the subject, here is the only useful
>> info i've found...
>> py-objfile-script-gdb.py consistently disappears after running the testsuite.
>
>
> I can't test this right now due to the binutils bug you reported.  When
> that is resolved, I will take a look.

Re: [patch] gdb.python tests, fix up paths

[Tom Tromey]

>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:

Matt> 2011-07-03  Matt Rice  <ratmice@gmail.com>
Matt>         * gdb.python/python.exp: Update filename paths.
Matt>         * gdb.python/py-symtab.exp: Ditto.

Ok.

Tom

Re: [patch] gdb.python tests, fix up paths

[Matt Rice]

2011/7/5 Tom Tromey <tromey@redhat.com>:
>>>>>> "Matt" == Matt Rice <ratmice@gmail.com> writes:
>
> Matt> 2011-07-03  Matt Rice  <ratmice@gmail.com>
> Matt>         * gdb.python/python.exp: Update filename paths.
> Matt>         * gdb.python/py-symtab.exp: Ditto.
>
> Ok.
>
> Tom
>

committed.