Re: [patch] gdb.python tests, fix up paths

Matt Rice
2011-07-04T10:29:30Z

On Mon, Jul 4, 2011 at 3:09 AM, Phil Muldoon <pmuldoon@redhat.com> wrote:
> Matt Rice <ratmice@gmail.com> writes:
>
>> This fixes some issues with the paths,
>> i'm seeing these all as './gdb.python/' here.
>>
>> 2011-07-03  Matt Rice  <ratmice@gmail.com>
>>
>>         * gdb.python/python.exp: Update filename paths.
>>         * gdb.python/py-symtab.exp: Ditto.
>
>> diff --git a/gdb/testsuite/gdb.python/py-symtab.exp b/gdb/testsuite/gdb.python/py-symtab.exp
>> index c52f5ef..ef35c5d 100644
>> --- a/gdb/testsuite/gdb.python/py-symtab.exp
>> +++ b/gdb/testsuite/gdb.python/py-symtab.exp
>> @@ -54,13 +54,13 @@ gdb_py_test_silent_cmd "python sal = frame.find_sal()" "Get block" 0
>> gdb_py_test_silent_cmd "python symtab = sal.symtab" "Get block" 0
>>
>> # Test sal.
>> -gdb_test "python print sal.symtab" "gdb/testsuite/gdb.python/py-symbol.c.*" "Test symtab"
>> +gdb_test "python print sal.symtab" ".*gdb.python/py-symbol.c.*" "Test symtab"
>
> While this is okay, and right now reflects how we test, I am curious to
> see what paths your testsuite instance is seeing.

without the patch for easier grepping:

./gdb.python/py-symbol.c
(gdb) FAIL: gdb.python/py-symtab.exp: Test symtab
--
./gdb.python/py-symbol.c
(gdb) FAIL: gdb.python/py-symtab.exp: Test symtab.filename
--
./gdb.python/python.c
(gdb) FAIL: gdb.python/python.exp: Test decode_line current locationn filename
--
./gdb.python/python.c
(gdb) FAIL: gdb.python/python.exp: Test decode_line python.c:26 filename
--
./gdb.python/python-1.c
(gdb) FAIL: gdb.python/python.exp: Test decode_line func1 filename

Are you building
> in-tree or out-of-tree (not that it matters beyond curiosity, the tests
> should work regardless).  Needs a testsuite/ChangeLog too.

building in-tree, guessing its probably
rm dest && cat src > dest but src == dest in the in-tree case. Hadn't
thought about out-of-tree i'll give it a try.

ChangeLog entry was at the top of the email (not included in diff though).

>> In addition to these, I'm getting another error I haven't been able to
>> figure out.
>> the logs are pretty silent on the subject, here is the only useful
>> info i've found...
>> py-objfile-script-gdb.py consistently disappears after running the testsuite.
>
>
> I can't test this right now due to the binutils bug you reported.  When
> that is resolved, I will take a look.