From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14607 invoked by alias); 4 Jul 2011 10:29:30 -0000 Received: (qmail 14595 invoked by uid 22791); 4 Jul 2011 10:29:29 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_BJ,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-yi0-f41.google.com (HELO mail-yi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jul 2011 10:29:15 +0000 Received: by yia13 with SMTP id 13so2363412yia.0 for ; Mon, 04 Jul 2011 03:29:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.110.40 with SMTP id t28mr4136134yhg.103.1309775355072; Mon, 04 Jul 2011 03:29:15 -0700 (PDT) Received: by 10.236.95.167 with HTTP; Mon, 4 Jul 2011 03:29:15 -0700 (PDT) In-Reply-To: References: Date: Mon, 04 Jul 2011 10:35:00 -0000 Message-ID: Subject: Re: [patch] gdb.python tests, fix up paths From: Matt Rice To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00085.txt.bz2 On Mon, Jul 4, 2011 at 3:09 AM, Phil Muldoon wrote: > Matt Rice writes: > >> This fixes some issues with the paths, >> i'm seeing these all as './gdb.python/' here. >> >> 2011-07-03 =A0Matt Rice =A0 >> >> =A0 =A0 =A0 =A0 * gdb.python/python.exp: Update filename paths. >> =A0 =A0 =A0 =A0 * gdb.python/py-symtab.exp: Ditto. > >> diff --git a/gdb/testsuite/gdb.python/py-symtab.exp b/gdb/testsuite/gdb.= python/py-symtab.exp >> index c52f5ef..ef35c5d 100644 >> --- a/gdb/testsuite/gdb.python/py-symtab.exp >> +++ b/gdb/testsuite/gdb.python/py-symtab.exp >> @@ -54,13 +54,13 @@ gdb_py_test_silent_cmd "python sal =3D frame.find_sa= l()" "Get block" 0 >> gdb_py_test_silent_cmd "python symtab =3D sal.symtab" "Get block" 0 >> >> # Test sal. >> -gdb_test "python print sal.symtab" "gdb/testsuite/gdb.python/py-symbol.= c.*" "Test symtab" >> +gdb_test "python print sal.symtab" ".*gdb.python/py-symbol.c.*" "Test s= ymtab" > > While this is okay, and right now reflects how we test, I am curious to > see what paths your testsuite instance is seeing. without the patch for easier grepping: ./gdb.python/py-symbol.c (gdb) FAIL: gdb.python/py-symtab.exp: Test symtab -- ./gdb.python/py-symbol.c (gdb) FAIL: gdb.python/py-symtab.exp: Test symtab.filename -- ./gdb.python/python.c (gdb) FAIL: gdb.python/python.exp: Test decode_line current locationn filen= ame -- ./gdb.python/python.c (gdb) FAIL: gdb.python/python.exp: Test decode_line python.c:26 filename -- ./gdb.python/python-1.c (gdb) FAIL: gdb.python/python.exp: Test decode_line func1 filename =A0Are you building > in-tree or out-of-tree (not that it matters beyond curiosity, the tests > should work regardless). =A0Needs a testsuite/ChangeLog too. building in-tree, guessing its probably rm dest && cat src > dest but src =3D=3D dest in the in-tree case. Hadn't thought about out-of-tree i'll give it a try. ChangeLog entry was at the top of the email (not included in diff though). >> In addition to these, I'm getting another error I haven't been able to >> figure out. >> the logs are pretty silent on the subject, here is the only useful >> info i've found... >> py-objfile-script-gdb.py consistently disappears after running the tests= uite. > > > I can't test this right now due to the binutils bug you reported. =A0When > that is resolved, I will take a look.