Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <xdje42@gmail.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	 Pierre-Marie de Rodat <derodat@adacore.com>
Subject: Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
Date: Thu, 13 Aug 2015 04:02:00 -0000	[thread overview]
Message-ID: <m3vbcj6dlg.fsf@sspiff.org> (raw)
In-Reply-To: <CABOHX+diCq3hB1g66c7hhoCgfJ9A67EiSBd-E99edrWHskWKbQ@mail.gmail.com>	(Iain Buclaw's message of "Mon, 3 Aug 2015 20:00:32 +0200")

Iain Buclaw <ibuclaw@gdcproject.org> writes:
> Third times a charm.
>
> Rebased this against master, in particular to make it compatible with
> the recent block_symbol additions.  I don't have a GCC-4.1 compiler at
> hand, but I don't think I'm doing anything that may trigger build
> warnings.  Pierre, maybe you want to confirm?
>
> I've also gotten round to completing the d-exp expression parser
> rewrite - or at least to a nice stable point.  Will be submitting that
> in patch #2.
>
> Regards
> Iain
>
> ---
>
> ---
> 2015-08-03  Iain Buclaw  <ibuclaw@gdcproject.org>
>
> 	* Makefile.in (SFILES): Add d-namespace.c.
> 	(COMMON_OBS): Add d-namespace.o.
> 	* d-lang.c (d_language_defn): Use d_lookup_symbol_nonlocal as the
> 	la_lookup_symbol_nonlocal callback function pointer.
> 	* d-lang.h (d_lookup_symbol_nonlocal): New declaration.
> 	(d_lookup_nested_symbol): New declaration.
> 	* d-namespace.c: New file.

Hi.
LGTM (with the one nit fixed that Pierre-Marie pointed out).


  parent reply	other threads:[~2015-08-13  4:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 18:00 Iain Buclaw
2015-08-04  8:27 ` Pierre-Marie de Rodat
2015-08-04 10:48   ` Iain Buclaw
2015-08-13  4:02 ` Doug Evans [this message]
2015-08-13 11:06   ` Iain Buclaw
2015-09-03 14:13 ` Yao Qi
2015-09-07 10:16   ` Iain Buclaw
2015-09-26  7:24   ` Iain Buclaw
2015-09-28 10:39     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vbcj6dlg.fsf@sspiff.org \
    --to=xdje42@gmail.com \
    --cc=derodat@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ibuclaw@gdcproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox