From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-125222-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 103351 invoked by alias); 13 Aug 2015 04:02:45 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 103321 invoked by uid 89); 13 Aug 2015 04:02:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pa0-f49.google.com
Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 13 Aug 2015 04:02:43 +0000
Received: by pacrr5 with SMTP id rr5so28491360pac.3        for <gdb-patches@sourceware.org>; Wed, 12 Aug 2015 21:02:42 -0700 (PDT)
X-Received: by 10.68.69.34 with SMTP id b2mr72885060pbu.119.1439438562154;        Wed, 12 Aug 2015 21:02:42 -0700 (PDT)
Received: from seba.sebabeach.org.gmail.com (173-13-178-53-sfba.hfc.comcastbusiness.net. [173.13.178.53])        by smtp.gmail.com with ESMTPSA id ml10sm713980pab.47.2015.08.12.21.02.41        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Wed, 12 Aug 2015 21:02:41 -0700 (PDT)
From: Doug Evans <xdje42@gmail.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: GDB Patches <gdb-patches@sourceware.org>,  Pierre-Marie de Rodat <derodat@adacore.com>
Subject: Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
References: <CABOHX+diCq3hB1g66c7hhoCgfJ9A67EiSBd-E99edrWHskWKbQ@mail.gmail.com>
Date: Thu, 13 Aug 2015 04:02:00 -0000
In-Reply-To: <CABOHX+diCq3hB1g66c7hhoCgfJ9A67EiSBd-E99edrWHskWKbQ@mail.gmail.com>	(Iain Buclaw's message of "Mon, 3 Aug 2015 20:00:32 +0200")
Message-ID: <m3vbcj6dlg.fsf@sspiff.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2015-08/txt/msg00337.txt.bz2

Iain Buclaw <ibuclaw@gdcproject.org> writes:
> Third times a charm.
>
> Rebased this against master, in particular to make it compatible with
> the recent block_symbol additions.  I don't have a GCC-4.1 compiler at
> hand, but I don't think I'm doing anything that may trigger build
> warnings.  Pierre, maybe you want to confirm?
>
> I've also gotten round to completing the d-exp expression parser
> rewrite - or at least to a nice stable point.  Will be submitting that
> in patch #2.
>
> Regards
> Iain
>
> ---
>
> ---
> 2015-08-03  Iain Buclaw  <ibuclaw@gdcproject.org>
>
> 	* Makefile.in (SFILES): Add d-namespace.c.
> 	(COMMON_OBS): Add d-namespace.o.
> 	* d-lang.c (d_language_defn): Use d_lookup_symbol_nonlocal as the
> 	la_lookup_symbol_nonlocal callback function pointer.
> 	* d-lang.h (d_lookup_symbol_nonlocal): New declaration.
> 	(d_lookup_nested_symbol): New declaration.
> 	* d-namespace.c: New file.

Hi.
LGTM (with the one nit fixed that Pierre-Marie pointed out).