Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules

[Iain Buclaw <ibuclaw@gdcproject.org>]

On 4 August 2015 at 10:27, Pierre-Marie de Rodat <derodat@adacore.com> wrote:
> Hello,
>
> On 08/03/2015 08:00 PM, Iain Buclaw wrote:
>>
>> Rebased this against master, in particular to make it compatible with
>> the recent block_symbol additions.  I don't have a GCC-4.1 compiler at
>> hand, but I don't think I'm doing anything that may trigger build
>> warnings.  Pierre, maybe you want to confirm?
>
>
> Well, I don't have easy access to one neither. ;-) I had a very quick look
> at your patch and it seems that all usage of block_symbol variables are
> dominated by at least one affectation (sym = lookup...), so I guess the
> problem Ulrich and Steve noticed should not arise here.
>
> ... except maybe in one place: in find_symbol_in_baseclass, the returned
> value is uninitialized if we don't enter the FOR loop (is that only possible
> in practice?). So what about providing {NULL, NULL} as an ininialization
> value to "sym", there?
>
> --
> Pierre-Marie de Rodat

Nice catch!  Yes, that seems reasonable.  I think in the original it
was initialized to NULL...

Regards
Iain.