From: Pierre-Marie de Rodat <derodat@adacore.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>,
GDB Patches <gdb-patches@sourceware.org>,
Doug Evans <xdje42@gmail.com>
Subject: Re: [PATCH v3 1/2] D: Support looking up symbols in the current and imported modules
Date: Tue, 04 Aug 2015 08:27:00 -0000 [thread overview]
Message-ID: <55C07787.9090605@adacore.com> (raw)
In-Reply-To: <CABOHX+diCq3hB1g66c7hhoCgfJ9A67EiSBd-E99edrWHskWKbQ@mail.gmail.com>
Hello,
On 08/03/2015 08:00 PM, Iain Buclaw wrote:
> Rebased this against master, in particular to make it compatible with
> the recent block_symbol additions. I don't have a GCC-4.1 compiler at
> hand, but I don't think I'm doing anything that may trigger build
> warnings. Pierre, maybe you want to confirm?
Well, I don't have easy access to one neither. ;-) I had a very quick
look at your patch and it seems that all usage of block_symbol variables
are dominated by at least one affectation (sym = lookup...), so I guess
the problem Ulrich and Steve noticed should not arise here.
... except maybe in one place: in find_symbol_in_baseclass, the returned
value is uninitialized if we don't enter the FOR loop (is that only
possible in practice?). So what about providing {NULL, NULL} as an
ininialization value to "sym", there?
--
Pierre-Marie de Rodat
next prev parent reply other threads:[~2015-08-04 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 18:00 Iain Buclaw
2015-08-04 8:27 ` Pierre-Marie de Rodat [this message]
2015-08-04 10:48 ` Iain Buclaw
2015-08-13 4:02 ` Doug Evans
2015-08-13 11:06 ` Iain Buclaw
2015-09-03 14:13 ` Yao Qi
2015-09-07 10:16 ` Iain Buclaw
2015-09-26 7:24 ` Iain Buclaw
2015-09-28 10:39 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C07787.9090605@adacore.com \
--to=derodat@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ibuclaw@gdcproject.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox