From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] Add is_base_class attribute to fields.
Date: Tue, 01 Dec 2009 20:51:00 -0000 [thread overview]
Message-ID: <m3tywamn8r.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B13A147.2040208@redhat.com> (Phil Muldoon's message of "Mon, 30 Nov 2009 10:41:11 +0000")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> Later I fixed a bug/added tests to capture a regression this
Phil> functionality caused.
Phil> http://sourceware.org/ml/archer/2009-q4/msg00016.html?
The tests are nice but they don't actually check the is_base_class field.
Could you add a test to do that?
Other than that I think the code bits are ok. It needs a doc review.
Phil> +# Run a command in GDB, and report a failure if a Python exception is
Phil> thrown.
Your mailer seems to have wrapped the patch.
Tom
next prev parent reply other threads:[~2009-12-01 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 10:41 Phil Muldoon
2009-12-01 20:51 ` Tom Tromey [this message]
2009-12-01 21:14 ` Phil Muldoon
2009-12-03 15:10 ` Phil Muldoon
2009-12-03 15:39 ` Eli Zaretskii
2009-12-03 16:06 ` Phil Muldoon
2009-12-03 21:28 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tywamn8r.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox