Re: [python][patch] Add is_base_class attribute to fields.

[Phil Muldoon <pmuldoon@redhat.com>]

On 12/01/2009 08:51 PM, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon<pmuldoon@redhat.com>  writes:
>
> Phil>  Later I fixed a bug/added tests to capture a regression this
> Phil>  functionality caused.
> Phil>  http://sourceware.org/ml/archer/2009-q4/msg00016.html?
>
> The tests are nice but they don't actually check the is_base_class field.
> Could you add a test to do that?

Sure, I'll add a test. The tests I added were testing a regression 
(#10805) for non C++ inferiors accessing fields, but were seg-fault'ing 
on the C++ specific parts of is_base_class (That was my contribution). 
But I take your point. The added tests should be pretty simple!

>
> Other than that I think the code bits are ok.  It needs a doc review.
>
> Phil>  +# Run a command in GDB, and report a failure if a Python exception is
> Phil>  thrown.
>
> Your mailer seems to have wrapped the patch.

Apologies. I just upgraded from F11 -> F12, and this is an in-line 
patch, something I don't normally do. I'll fix the relevant regressive 
Thunderbird bits for next time.

Cheers,

Phil