From: Eli Zaretskii <eliz@gnu.org>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [python][patch] Add is_base_class attribute to fields.
Date: Thu, 03 Dec 2009 15:39:00 -0000 [thread overview]
Message-ID: <E1NGDmO-0000E7-Ta@fencepost.gnu.org> (raw)
In-Reply-To: <4B17D4C3.1040703@redhat.com> (message from Phil Muldoon on Thu, 03 Dec 2009 15:09:55 +0000)
> Date: Thu, 03 Dec 2009 15:09:55 +0000
> From: Phil Muldoon <pmuldoon@redhat.com>
> CC: gdb-patches ml <gdb-patches@sourceware.org>
>
> I've modified the patch as attached. If Eli does not have any comments or
> changes to the doc section, this is what I will commit.
The doco part is okay, except for one issue:
> +structure. This attribute is always provided, and is @code{False}
> +if the field is not a base class of the type on which @code{fields} was
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +called, or if that type was not a C@t{++} class.
^^^^^^
I think ``the type that is the argument of @code{fields}'' is much
more clear (unless I misunderstood what you wanted to say).
Thanks.
next prev parent reply other threads:[~2009-12-03 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 10:41 Phil Muldoon
2009-12-01 20:51 ` Tom Tromey
2009-12-01 21:14 ` Phil Muldoon
2009-12-03 15:10 ` Phil Muldoon
2009-12-03 15:39 ` Eli Zaretskii [this message]
2009-12-03 16:06 ` Phil Muldoon
2009-12-03 21:28 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1NGDmO-0000E7-Ta@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox