From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27476 invoked by alias); 3 Dec 2009 15:39:49 -0000 Received: (qmail 27468 invoked by uid 22791); 3 Dec 2009 15:39:48 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_20,SPF_PASS X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Dec 2009 15:39:42 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NGDmO-0000E7-Ta; Thu, 03 Dec 2009 10:39:40 -0500 From: Eli Zaretskii To: Phil Muldoon CC: tromey@redhat.com, gdb-patches@sourceware.org In-reply-to: <4B17D4C3.1040703@redhat.com> (message from Phil Muldoon on Thu, 03 Dec 2009 15:09:55 +0000) Subject: Re: [python][patch] Add is_base_class attribute to fields. Reply-to: Eli Zaretskii References: <4B13A147.2040208@redhat.com> <4B17D4C3.1040703@redhat.com> Message-Id: Date: Thu, 03 Dec 2009 15:39:00 -0000 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00028.txt.bz2 > Date: Thu, 03 Dec 2009 15:09:55 +0000 > From: Phil Muldoon > CC: gdb-patches ml > > I've modified the patch as attached. If Eli does not have any comments or > changes to the doc section, this is what I will commit. The doco part is okay, except for one issue: > +structure. This attribute is always provided, and is @code{False} > +if the field is not a base class of the type on which @code{fields} was ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > +called, or if that type was not a C@t{++} class. ^^^^^^ I think ``the type that is the argument of @code{fields}'' is much more clear (unless I misunderstood what you wanted to say). Thanks.