From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1834 invoked by alias); 1 Dec 2009 20:51:40 -0000 Received: (qmail 1824 invoked by uid 22791); 1 Dec 2009 20:51:39 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Dec 2009 20:51:35 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB1KpXvG010096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Dec 2009 15:51:33 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB1KpX27010959; Tue, 1 Dec 2009 15:51:33 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nB1KpWsw001162; Tue, 1 Dec 2009 15:51:32 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 49B32378190; Tue, 1 Dec 2009 13:51:32 -0700 (MST) From: Tom Tromey To: Phil Muldoon Cc: gdb-patches ml Subject: Re: [python][patch] Add is_base_class attribute to fields. References: <4B13A147.2040208@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 01 Dec 2009 20:51:00 -0000 In-Reply-To: <4B13A147.2040208@redhat.com> (Phil Muldoon's message of "Mon, 30 Nov 2009 10:41:11 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00005.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> Later I fixed a bug/added tests to capture a regression this Phil> functionality caused. Phil> http://sourceware.org/ml/archer/2009-q4/msg00016.html? The tests are nice but they don't actually check the is_base_class field. Could you add a test to do that? Other than that I think the code bits are ok. It needs a doc review. Phil> +# Run a command in GDB, and report a failure if a Python exception is Phil> thrown. Your mailer seems to have wrapped the patch. Tom