Re: [PATCH 6/7] New JIT unwinder.

[Sergio Durigan Junior <sergiodj@redhat.com>]

Hi Sanjoy,

Thanks for the work.  There are a few nits.

Sanjoy Das <sanjoy@playingwithpointers.com> writes:

> diff --git a/gdb/jit.c b/gdb/jit.c
> index 3be8c4d..fa25908 100644
> --- a/gdb/jit.c
> +++ b/gdb/jit.c
> @@ -31,6 +31,7 @@
>  #include "inferior.h"
>  #include "observer.h"
>  #include "objfiles.h"
> +#include "regcache.h"
>  #include "symfile.h"
>  #include "symtab.h"
>  #include "target.h"
> @@ -49,6 +50,12 @@ static const struct inferior_data *jit_inferior_data = NULL;
>  
>  static void jit_inferior_init (struct gdbarch *gdbarch);
>  
> +/* An unwinder is registered for every gdbarch. This key is used to
> +   remember if the unwinder has been registered for a particular
> +   gdbarch. */

All over the code, you should put two spaces after a dot or a period.
Please fix that.

> +/* Passed in the `free' field of a gdb_reg_value. */
> +
> +static void
> +free_reg_value_impl (struct gdb_reg_value *reg_value)
> +{
> +  xfree (reg_value);
> +}

Sorry, I don't think this function is needed.  All it does is to call
`xfree'.  You should be able to call `xfree' directly when needed.

Thanks,

Sergio.