Re: [PATCH 6/7] New JIT unwinder.

[Tom Tromey <tromey@redhat.com>]

>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:

Sanjoy> Introduce a "proxy unwinder", whcih will pass down all calls to the
Sanjoy> functions the JIT reader provides.

Sanjoy> +  value->free = (void (*) (struct gdb_reg_value *)) xfree;

I think either the free function's type should be changed, or you should
go back to the previous version here.  Function casts are bad, we should
avoid them as much as possible.  My preference is for the previous patch
as I think the earlier critique was mistaken, but I am ok with either
approach.

Sanjoy> +static enum unwind_stop_reason
Sanjoy> +jit_frame_unwind_stop_reason (struct frame_info *this_frame, void **cache)
Sanjoy> +{
Sanjoy> +  return default_frame_unwind_stop_reason (this_frame, cache);
Sanjoy> +}

I think you can just delete this function and put
default_frame_unwind_stop_reason directly into jit_frame_unwind.

Otherwise this looks good to me.

Tom