From: Tom Tromey <tromey@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/7] Introduce jit-reader.in and modify build system.
Date: Tue, 30 Aug 2011 18:30:00 -0000 [thread overview]
Message-ID: <m3d3fmbvmu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1314518609-10204-2-git-send-email-sanjoy@playingwithpointers.com> (Sanjoy Das's message of "Sun, 28 Aug 2011 13:33:23 +0530")
>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:
Sanjoy> jit-reader.in will host the interface to be implemented and the API to
Sanjoy> be used by the reader. The file needs to be processed by ./configure
Sanjoy> to produce `jit.reader.h'; so that GDB_CORE_ADDR is defined correctly.
Thanks for persevering with this patch series.
I think it is an important addition to gdb.
Sanjoy> gdb/ChangeLog:
Sanjoy> * gdb/Makefile.in: Add jit-reader.h as a header. Have it
Sanjoy> installed in $(includedir)/gdb.
Sanjoy> * gdb/configure.ac: Genereate a correct value for TARGET_PTR for
Sanjoy> jit-reader.h. Tell configure to generate jit-reader.h from
Sanjoy> jit-reader.in.
Sanjoy> * gdb/configure: Re-generated by autoconf.
Sanjoy> * gdb/jit-reader.in: New file.
Sanjoy> * gdb/jit.c: Include jit-reader.h.
One final nit from me on this patch.
Sanjoy> + $(SHELL) $(srcdir)/../mkinstalldirs $(includedir)/gdb ; \
Sanjoy> + $(INSTALL_DATA) jit-reader.h $(includedir)/gdb/jit-reader.h
This should have $(DESTDIR) in it, see the rest of this rule.
This patch is ok with this change.
I haven't been keeping track of your assignment status.
Has everything gone through?
Tom
next prev parent reply other threads:[~2011-08-30 18:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 13:08 JIT Debug Info Reader Sanjoy Das
2011-08-27 13:08 ` [PATCH 1/7] Introduce jit-reader.in and modify build system Sanjoy Das
2011-08-27 13:08 ` [PATCH 7/7] Documentation Sanjoy Das
2011-08-27 13:08 ` [PATCH 2/7] Relocatable directory for loading JIT readers Sanjoy Das
2011-08-27 13:08 ` [PATCH 3/7] Platform agnostic dynamic loading code Sanjoy Das
2011-08-27 13:08 ` [PATCH 5/7] Use the loaded reader Sanjoy Das
2011-08-27 13:47 ` Abhijit Halder
2011-08-27 14:18 ` Abhijit Halder
2011-08-27 13:08 ` [PATCH 6/7] New JIT unwinder Sanjoy Das
2011-08-28 2:17 ` Sergio Durigan Junior
[not found] ` <1314518609-10204-1-git-send-email-sanjoy@playingwithpointers.com>
2011-08-28 8:04 ` [PATCH 5/7] Use the loaded reader Sanjoy Das
2011-08-30 19:18 ` Tom Tromey
2011-08-28 8:04 ` [PATCH 7/7] Documentation Sanjoy Das
2011-08-30 19:43 ` Tom Tromey
2011-08-28 8:04 ` [PATCH 3/7] Platform agnostic dynamic loading code Sanjoy Das
2011-08-28 8:04 ` [PATCH 4/7] New commands for loading and unloading a reader Sanjoy Das
2011-08-30 18:52 ` Tom Tromey
2011-08-28 8:04 ` [PATCH 6/7] New JIT unwinder Sanjoy Das
2011-08-30 19:28 ` Tom Tromey
2011-08-28 8:05 ` [PATCH 2/7] Relocatable directory for loading JIT readers Sanjoy Das
2011-08-30 18:32 ` Tom Tromey
2011-08-28 8:07 ` [PATCH 1/7] Introduce jit-reader.in and modify build system Sanjoy Das
2011-08-30 18:30 ` Tom Tromey [this message]
2011-08-31 3:16 ` Sanjoy Das
2011-08-31 17:44 ` Tom Tromey
2011-08-27 13:08 ` [PATCH 4/7] New commands for loading and unloading a reader Sanjoy Das
2011-08-27 14:51 ` Abhijit Halder
-- strict thread matches above, loose matches on Subject: below --
2011-08-31 3:31 JIT Reader (re-roll) Sanjoy Das
2011-08-31 3:31 ` [PATCH 1/7] Introduce jit-reader.in and modify build system Sanjoy Das
2011-08-24 18:57 JIT Debug Info Reader (re-roll) Sanjoy Das
2011-08-24 18:57 ` [PATCH 1/7] Introduce jit-reader.in and modify build system Sanjoy Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3fmbvmu.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sanjoy@playingwithpointers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox