From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26387 invoked by alias); 30 Aug 2011 18:30:08 -0000 Received: (qmail 26371 invoked by uid 22791); 30 Aug 2011 18:30:07 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 18:29:48 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7UITlTw023167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 14:29:47 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7UITlmd021280; Tue, 30 Aug 2011 14:29:47 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7UITjrE028803; Tue, 30 Aug 2011 14:29:46 -0400 From: Tom Tromey To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] Introduce jit-reader.in and modify build system. References: <1314450736-19389-7-git-send-email-sanjoy@playingwithpointers.com> <1314518609-10204-1-git-send-email-sanjoy@playingwithpointers.com> <1314518609-10204-2-git-send-email-sanjoy@playingwithpointers.com> Date: Tue, 30 Aug 2011 18:30:00 -0000 In-Reply-To: <1314518609-10204-2-git-send-email-sanjoy@playingwithpointers.com> (Sanjoy Das's message of "Sun, 28 Aug 2011 13:33:23 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00624.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> jit-reader.in will host the interface to be implemented and the API to Sanjoy> be used by the reader. The file needs to be processed by ./configure Sanjoy> to produce `jit.reader.h'; so that GDB_CORE_ADDR is defined correctly. Thanks for persevering with this patch series. I think it is an important addition to gdb. Sanjoy> gdb/ChangeLog: Sanjoy> * gdb/Makefile.in: Add jit-reader.h as a header. Have it Sanjoy> installed in $(includedir)/gdb. Sanjoy> * gdb/configure.ac: Genereate a correct value for TARGET_PTR for Sanjoy> jit-reader.h. Tell configure to generate jit-reader.h from Sanjoy> jit-reader.in. Sanjoy> * gdb/configure: Re-generated by autoconf. Sanjoy> * gdb/jit-reader.in: New file. Sanjoy> * gdb/jit.c: Include jit-reader.h. One final nit from me on this patch. Sanjoy> + $(SHELL) $(srcdir)/../mkinstalldirs $(includedir)/gdb ; \ Sanjoy> + $(INSTALL_DATA) jit-reader.h $(includedir)/gdb/jit-reader.h This should have $(DESTDIR) in it, see the rest of this rule. This patch is ok with this change. I haven't been keeping track of your assignment status. Has everything gone through? Tom