From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2584 invoked by alias); 30 Aug 2011 19:28:15 -0000 Received: (qmail 2575 invoked by uid 22791); 30 Aug 2011 19:28:14 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_WH X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 19:27:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7UJRuLu028883 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Aug 2011 15:27:56 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7UJRtYb002075; Tue, 30 Aug 2011 15:27:56 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7UJRsGE006059; Tue, 30 Aug 2011 15:27:54 -0400 From: Tom Tromey To: Sanjoy Das Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 6/7] New JIT unwinder. References: <1314450736-19389-7-git-send-email-sanjoy@playingwithpointers.com> <1314518609-10204-1-git-send-email-sanjoy@playingwithpointers.com> <1314518609-10204-7-git-send-email-sanjoy@playingwithpointers.com> Date: Tue, 30 Aug 2011 19:28:00 -0000 In-Reply-To: <1314518609-10204-7-git-send-email-sanjoy@playingwithpointers.com> (Sanjoy Das's message of "Sun, 28 Aug 2011 13:33:28 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00630.txt.bz2 >>>>> "Sanjoy" == Sanjoy Das writes: Sanjoy> Introduce a "proxy unwinder", whcih will pass down all calls to the Sanjoy> functions the JIT reader provides. Sanjoy> + value->free = (void (*) (struct gdb_reg_value *)) xfree; I think either the free function's type should be changed, or you should go back to the previous version here. Function casts are bad, we should avoid them as much as possible. My preference is for the previous patch as I think the earlier critique was mistaken, but I am ok with either approach. Sanjoy> +static enum unwind_stop_reason Sanjoy> +jit_frame_unwind_stop_reason (struct frame_info *this_frame, void **cache) Sanjoy> +{ Sanjoy> + return default_frame_unwind_stop_reason (this_frame, cache); Sanjoy> +} I think you can just delete this function and put default_frame_unwind_stop_reason directly into jit_frame_unwind. Otherwise this looks good to me. Tom