From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83276-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23214 invoked by alias); 28 Aug 2011 02:17:00 -0000
Received: (qmail 23204 invoked by uid 22791); 28 Aug 2011 02:16:58 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 28 Aug 2011 02:16:41 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7S2GeOQ009380	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Sat, 27 Aug 2011 22:16:40 -0400
Received: from psique ([10.3.112.13])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7S2GZcI001361;	Sat, 27 Aug 2011 22:16:38 -0400
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Sanjoy Das <sanjoy@playingwithpointers.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 6/7] New JIT unwinder.
References: <1314450736-19389-1-git-send-email-sanjoy@playingwithpointers.com>	<1314450736-19389-7-git-send-email-sanjoy@playingwithpointers.com>
Date: Sun, 28 Aug 2011 02:17:00 -0000
In-Reply-To: <1314450736-19389-7-git-send-email-sanjoy@playingwithpointers.com>	(Sanjoy Das's message of "Sat, 27 Aug 2011 18:42:15 +0530")
Message-ID: <m3ty921drx.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00536.txt.bz2

Hi Sanjoy,

Thanks for the work.  There are a few nits.

Sanjoy Das <sanjoy@playingwithpointers.com> writes:

> diff --git a/gdb/jit.c b/gdb/jit.c
> index 3be8c4d..fa25908 100644
> --- a/gdb/jit.c
> +++ b/gdb/jit.c
> @@ -31,6 +31,7 @@
>  #include "inferior.h"
>  #include "observer.h"
>  #include "objfiles.h"
> +#include "regcache.h"
>  #include "symfile.h"
>  #include "symtab.h"
>  #include "target.h"
> @@ -49,6 +50,12 @@ static const struct inferior_data *jit_inferior_data = NULL;
>  
>  static void jit_inferior_init (struct gdbarch *gdbarch);
>  
> +/* An unwinder is registered for every gdbarch. This key is used to
> +   remember if the unwinder has been registered for a particular
> +   gdbarch. */

All over the code, you should put two spaces after a dot or a period.
Please fix that.

> +/* Passed in the `free' field of a gdb_reg_value. */
> +
> +static void
> +free_reg_value_impl (struct gdb_reg_value *reg_value)
> +{
> +  xfree (reg_value);
> +}

Sorry, I don't think this function is needed.  All it does is to call
`xfree'.  You should be able to call `xfree' directly when needed.

Thanks,

Sergio.