Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	        "gdb-patches\@sourceware.org"
	<gdb-patches@sourceware.org>,
	        "glaw\@undo-software.com" <glaw@undo-software.com>,
	        "jakob\@virtutech.com" <jakob@virtutech.com>,
	        "teawater\@gmail.com" <teawater@gmail.com>
Subject: Re: [RFA] replay bookmarks
Date: Mon, 09 Nov 2009 17:55:00 -0000	[thread overview]
Message-ID: <m3skcninwe.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4AEE27E9.1070005@vmware.com> (Michael Snyder's message of "Sun, 	01 Nov 2009 16:29:29 -0800")

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> How about this?

Michael> +struct bookmark *bookmark_chain;
Michael> +int bookmark_count;

These should be static.

Michael> +static int
Michael> +delete_one_bookmark (struct bookmark *b)
Michael> +{
[...]
Michael> +  /* Find bookmark preceeding "marked" one, so we can unlink.  */
Michael> +  /* FIXME what about end cases (first and last)?  */

We're trying to avoid new FIXMEs.

I think instead of using ALL_BOOKMARKS this code would be simpler and
more obviously correct if it just had an explicit loop.  There's no need
to have a special case for the first element of the list, either.  E.g.,
see the deletion code in cli-decode.c:delete_cmd.

Tom


  parent reply	other threads:[~2009-11-09 17:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01 21:13 Michael Snyder
2009-11-01 21:23 ` Eli Zaretskii
2009-11-02  0:29   ` Michael Snyder
2009-11-02  4:01     ` Eli Zaretskii
2009-11-03  8:34       ` Jakob Engblom
2009-11-03  8:36         ` Hui Zhu
2009-11-03 18:42         ` Michael Snyder
2009-11-05 11:05           ` Jakob Engblom
2009-11-03  8:35     ` Hui Zhu
2009-11-05 18:13       ` Michael Snyder
2009-11-05 18:44         ` Pedro Alves
2009-11-05 19:17         ` Eli Zaretskii
2009-11-05 23:40           ` Michael Snyder
2009-11-06  8:34             ` Eli Zaretskii
2009-11-09 17:55     ` Tom Tromey [this message]
2009-11-10 22:09       ` Michael Snyder
2009-11-10 22:27         ` Tom Tromey
2009-11-11  4:15         ` Eli Zaretskii
2009-11-11 18:33           ` Michael Snyder
2009-11-11 18:44             ` Eli Zaretskii
2009-11-20 17:26               ` Michael Snyder
2009-11-23  3:20                 ` Hui Zhu
2009-12-04  9:09                   ` Jakob Engblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3skcninwe.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=glaw@undo-software.com \
    --cc=jakob@virtutech.com \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox