From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32346 invoked by alias); 9 Nov 2009 17:55:31 -0000 Received: (qmail 32338 invoked by uid 22791); 9 Nov 2009 17:55:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 17:55:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HtMpi030715; Mon, 9 Nov 2009 12:55:22 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HtJ45031050; Mon, 9 Nov 2009 12:55:19 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nA9HtDHT009744; Mon, 9 Nov 2009 12:55:14 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9C6F337815E; Mon, 9 Nov 2009 10:55:13 -0700 (MST) From: Tom Tromey To: Michael Snyder Cc: Eli Zaretskii , "gdb-patches\@sourceware.org" , "glaw\@undo-software.com" , "jakob\@virtutech.com" , "teawater\@gmail.com" Subject: Re: [RFA] replay bookmarks References: <4AEDF9F4.9040207@vmware.com> <834opec530.fsf@gnu.org> <4AEE27E9.1070005@vmware.com> Reply-To: tromey@redhat.com Date: Mon, 09 Nov 2009 17:55:00 -0000 In-Reply-To: <4AEE27E9.1070005@vmware.com> (Michael Snyder's message of "Sun, 01 Nov 2009 16:29:29 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00151.txt.bz2 >>>>> "Michael" == Michael Snyder writes: Michael> How about this? Michael> +struct bookmark *bookmark_chain; Michael> +int bookmark_count; These should be static. Michael> +static int Michael> +delete_one_bookmark (struct bookmark *b) Michael> +{ [...] Michael> + /* Find bookmark preceeding "marked" one, so we can unlink. */ Michael> + /* FIXME what about end cases (first and last)? */ We're trying to avoid new FIXMEs. I think instead of using ALL_BOOKMARKS this code would be simpler and more obviously correct if it just had an explicit loop. There's no need to have a special case for the first element of the list, either. E.g., see the deletion code in cli-decode.c:delete_cmd. Tom