From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>,
Hui Zhu <teawater@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
"glaw@undo-software.com" <glaw@undo-software.com>,
"jakob@virtutech.com" <jakob@virtutech.com>
Subject: Re: [RFA] replay bookmarks
Date: Thu, 05 Nov 2009 18:44:00 -0000 [thread overview]
Message-ID: <200911051844.40394.pedro@codesourcery.com> (raw)
In-Reply-To: <4AF315B5.3070809@vmware.com>
On Thursday 05 November 2009 18:13:09, Michael Snyder wrote:
> Hui Zhu wrote:
> > I try this patch in i386 ubuntu. It works very good.
> >
> > Could you add some works in cmd help to talk about "begin" and "end"?
>
> Added, plus a few more _()'s, per comment from Eli.
Quick comments:
- any chance you could use packet_ok?
- '||'s at beginning of line, not at end.
- You should be bin2hex/hex2bin'ing the strings that are
being xfered over the wire.
--
Pedro Alves
next prev parent reply other threads:[~2009-11-05 18:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-01 21:13 Michael Snyder
2009-11-01 21:23 ` Eli Zaretskii
2009-11-02 0:29 ` Michael Snyder
2009-11-02 4:01 ` Eli Zaretskii
2009-11-03 8:34 ` Jakob Engblom
2009-11-03 8:36 ` Hui Zhu
2009-11-03 18:42 ` Michael Snyder
2009-11-05 11:05 ` Jakob Engblom
2009-11-03 8:35 ` Hui Zhu
2009-11-05 18:13 ` Michael Snyder
2009-11-05 18:44 ` Pedro Alves [this message]
2009-11-05 19:17 ` Eli Zaretskii
2009-11-05 23:40 ` Michael Snyder
2009-11-06 8:34 ` Eli Zaretskii
2009-11-09 17:55 ` Tom Tromey
2009-11-10 22:09 ` Michael Snyder
2009-11-10 22:27 ` Tom Tromey
2009-11-11 4:15 ` Eli Zaretskii
2009-11-11 18:33 ` Michael Snyder
2009-11-11 18:44 ` Eli Zaretskii
2009-11-20 17:26 ` Michael Snyder
2009-11-23 3:20 ` Hui Zhu
2009-12-04 9:09 ` Jakob Engblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911051844.40394.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=glaw@undo-software.com \
--cc=jakob@virtutech.com \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox