From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20815 invoked by alias); 5 Nov 2009 18:44:45 -0000 Received: (qmail 20805 invoked by uid 22791); 5 Nov 2009 18:44:44 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Nov 2009 18:44:40 +0000 Received: (qmail 24556 invoked from network); 5 Nov 2009 18:44:38 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Nov 2009 18:44:38 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] replay bookmarks Date: Thu, 05 Nov 2009 18:44:00 -0000 User-Agent: KMail/1.9.10 Cc: Michael Snyder , Hui Zhu , Eli Zaretskii , "glaw@undo-software.com" , "jakob@virtutech.com" References: <4AEDF9F4.9040207@vmware.com> <4AF315B5.3070809@vmware.com> In-Reply-To: <4AF315B5.3070809@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200911051844.40394.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00093.txt.bz2 On Thursday 05 November 2009 18:13:09, Michael Snyder wrote: > Hui Zhu wrote: > > I try this patch in i386 ubuntu. It works very good. > > > > Could you add some works in cmd help to talk about "begin" and "end"? > > Added, plus a few more _()'s, per comment from Eli. Quick comments: - any chance you could use packet_ok? - '||'s at beginning of line, not at end. - You should be bin2hex/hex2bin'ing the strings that are being xfered over the wire. -- Pedro Alves