Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Jakob Engblom <jakob@virtutech.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Michael Snyder <msnyder@vmware.com>,
	gdb-patches@sourceware.org,  	glaw@undo-software.com
Subject: Re: [RFA] replay bookmarks
Date: Tue, 03 Nov 2009 08:36:00 -0000	[thread overview]
Message-ID: <daef60380911030036r6fb3e264rf068bf87ddc5f2ef@mail.gmail.com> (raw)
In-Reply-To: <001101ca5c60$7220f9e0$5662eda0$@com>

On Tue, Nov 3, 2009 at 16:34, Jakob Engblom <jakob@virtutech.com> wrote:
>> > >> Date: Sun, 01 Nov 2009 13:13:24 -0800
>> > >> From: Michael Snyder <msnyder@vmware.com>
>> > >>
>> > >> +  add_com ("bookmark", class_bookmark, save_bookmark_command, _("\
>> > >> +Set a bookmark.\n\
>> > >
>> > > This is way too short.  Suggest to expand a bit:
>> > >
>> > >   Set a bookmark in the inferior's execution history
>> > >
>> > >> +  add_com ("goto-bookmark", class_bookmark, goto_bookmark_command, _("\
>> > >> +Go to bookmark <n>\n\
>> > >
>> > > Similarly here: such a short description is hardly useful, as it just
>> > > repeats the name of the command.
>> >
>> > How about this?
>>
>> Fine with me.
>>
>> There are a few instances of user messages where the text is not
>> marked by _().
>>
>> Also, we will need an update for the manual, once this is approved.
>
> Also, will this add corresponding operations to gdb-serial? That is necessary to
> get this working for undodb, Simics, and similar remote-exec bookmarkable
> targets.  I guess that also means VMWare, right?
>

       * remote.c (remote_get_bookmark): New target method.
       (remote_goto_bookmark): New target method.

Is it you looking for?

Thanks,
Hui


  reply	other threads:[~2009-11-03  8:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01 21:13 Michael Snyder
2009-11-01 21:23 ` Eli Zaretskii
2009-11-02  0:29   ` Michael Snyder
2009-11-02  4:01     ` Eli Zaretskii
2009-11-03  8:34       ` Jakob Engblom
2009-11-03  8:36         ` Hui Zhu [this message]
2009-11-03 18:42         ` Michael Snyder
2009-11-05 11:05           ` Jakob Engblom
2009-11-03  8:35     ` Hui Zhu
2009-11-05 18:13       ` Michael Snyder
2009-11-05 18:44         ` Pedro Alves
2009-11-05 19:17         ` Eli Zaretskii
2009-11-05 23:40           ` Michael Snyder
2009-11-06  8:34             ` Eli Zaretskii
2009-11-09 17:55     ` Tom Tromey
2009-11-10 22:09       ` Michael Snyder
2009-11-10 22:27         ` Tom Tromey
2009-11-11  4:15         ` Eli Zaretskii
2009-11-11 18:33           ` Michael Snyder
2009-11-11 18:44             ` Eli Zaretskii
2009-11-20 17:26               ` Michael Snyder
2009-11-23  3:20                 ` Hui Zhu
2009-12-04  9:09                   ` Jakob Engblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380911030036r6fb3e264rf068bf87ddc5f2ef@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=glaw@undo-software.com \
    --cc=jakob@virtutech.com \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox