From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68138-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26143 invoked by alias); 3 Nov 2009 08:36:37 -0000
Received: (qmail 26134 invoked by uid 22791); 3 Nov 2009 08:36:37 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-px0-f189.google.com (HELO mail-px0-f189.google.com) (209.85.216.189)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Nov 2009 08:36:33 +0000
Received: by pxi27 with SMTP id 27so3987603pxi.25         for <gdb-patches@sourceware.org>; Tue, 03 Nov 2009 00:36:32 -0800 (PST)
MIME-Version: 1.0
Received: by 10.142.4.4 with SMTP id 4mr1003792wfd.214.1257237392082; Tue, 03  	Nov 2009 00:36:32 -0800 (PST)
In-Reply-To: <001101ca5c60$7220f9e0$5662eda0$@com>
References: <4AEDF9F4.9040207@vmware.com> <834opec530.fsf@gnu.org>  	<4AEE27E9.1070005@vmware.com> <831vkhd18a.fsf@gnu.org> <001101ca5c60$7220f9e0$5662eda0$@com>
From: Hui Zhu <teawater@gmail.com>
Date: Tue, 03 Nov 2009 08:36:00 -0000
Message-ID: <daef60380911030036r6fb3e264rf068bf87ddc5f2ef@mail.gmail.com>
Subject: Re: [RFA] replay bookmarks
To: Jakob Engblom <jakob@virtutech.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Michael Snyder <msnyder@vmware.com>, gdb-patches@sourceware.org,  	glaw@undo-software.com
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00045.txt.bz2

On Tue, Nov 3, 2009 at 16:34, Jakob Engblom <jakob@virtutech.com> wrote:
>> > >> Date: Sun, 01 Nov 2009 13:13:24 -0800
>> > >> From: Michael Snyder <msnyder@vmware.com>
>> > >>
>> > >> + =A0add_com ("bookmark", class_bookmark, save_bookmark_command, _(=
"\
>> > >> +Set a bookmark.\n\
>> > >
>> > > This is way too short. =A0Suggest to expand a bit:
>> > >
>> > > =A0 Set a bookmark in the inferior's execution history
>> > >
>> > >> + =A0add_com ("goto-bookmark", class_bookmark, goto_bookmark_comman=
d, _("\
>> > >> +Go to bookmark <n>\n\
>> > >
>> > > Similarly here: such a short description is hardly useful, as it just
>> > > repeats the name of the command.
>> >
>> > How about this?
>>
>> Fine with me.
>>
>> There are a few instances of user messages where the text is not
>> marked by _().
>>
>> Also, we will need an update for the manual, once this is approved.
>
> Also, will this add corresponding operations to gdb-serial? That is neces=
sary to
> get this working for undodb, Simics, and similar remote-exec bookmarkable
> targets. =A0I guess that also means VMWare, right?
>

       * remote.c (remote_get_bookmark): New target method.
       (remote_goto_bookmark): New target method.

Is it you looking for?

Thanks,
Hui