Re: [PATCH] Fix complex argument handling in ppc64 dummy function call

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Friday, March 01 2013, Tiago Stürmer Daitx wrote:

> Sergio, many thanks for the thorough review and the tips. There's no better 
> way to get these rules to stick in my head. ^_^

Thanks a lot!

> Let me know if there is still something amiss.

Just one little thing :-).

> +          else if (TYPE_CODE (type) == TYPE_CODE_COMPLEX
> +              && (TYPE_LENGTH (type) == 8 || TYPE_LENGTH (type) == 16))
> +            {
> +              int i;
> +
> +              for (i = 0; i < 2; i++)
> +                {
> +		  if (write_pass)
> +		    {
> +		      struct type *target_type;
> +
> +		      target_type = check_typedef (TYPE_TARGET_TYPE (type));
> +		      ppc64_sysv_abi_push_float (gdbarch, regcache, tdep,
> +						 target_type, val + i *
> +						 TYPE_LENGTH (target_type),
> +						 freg, greg, gparam);
> +		    }
> +                  freg++;
> +                  greg++;
> +                  /* Always consume parameter stack space.  */
> +                  gparam = align_up(gparam + 8, tdep->wordsize);

Space between the function name and its arguments.  It should read:

      align_up (gparam....);

But don't bother sending the patch again just for that little nit.  When
the patch gets reviewed/accepted, just commit it with the proper fix
:-).

Thanks again,

-- 
Sergio