From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5722 invoked by alias); 1 Mar 2013 18:57:25 -0000 Received: (qmail 5714 invoked by uid 22791); 1 Mar 2013 18:57:25 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 18:57:15 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r21Iv6ON030808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Mar 2013 13:57:07 -0500 Received: from psique (ovpn-113-23.phx2.redhat.com [10.3.113.23]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r21Iv37s012885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 1 Mar 2013 13:57:05 -0500 From: Sergio Durigan Junior To: Tiago =?utf-8?Q?St=C3=BCrmer?= Daitx Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix complex argument handling in ppc64 dummy function call In-Reply-To: <20130301170811.EFEA2300943@igoo.rch.stglabs.ibm.com> ("Tiago =?utf-8?Q?St=C3=BCrmer?= Daitx"'s message of "Fri, 1 Mar 2013 11:08:11 -0600 (CST)") References: <20130301170811.EFEA2300943@igoo.rch.stglabs.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) X-URL: http://www.redhat.com Date: Fri, 01 Mar 2013 18:57:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00039.txt.bz2 On Friday, March 01 2013, Tiago St=C3=BCrmer Daitx wrote: > Sergio, many thanks for the thorough review and the tips. There's no bett= er=20 > way to get these rules to stick in my head. ^_^ Thanks a lot! > Let me know if there is still something amiss. Just one little thing :-). > + else if (TYPE_CODE (type) =3D=3D TYPE_CODE_COMPLEX > + && (TYPE_LENGTH (type) =3D=3D 8 || TYPE_LENGTH (type) =3D= =3D 16)) > + { > + int i; > + > + for (i =3D 0; i < 2; i++) > + { > + if (write_pass) > + { > + struct type *target_type; > + > + target_type =3D check_typedef (TYPE_TARGET_TYPE (type)); > + ppc64_sysv_abi_push_float (gdbarch, regcache, tdep, > + target_type, val + i * > + TYPE_LENGTH (target_type), > + freg, greg, gparam); > + } > + freg++; > + greg++; > + /* Always consume parameter stack space. */ > + gparam =3D align_up(gparam + 8, tdep->wordsize); Space between the function name and its arguments. It should read: align_up (gparam....); But don't bother sending the patch again just for that little nit. When the patch gets reviewed/accepted, just commit it with the proper fix :-). Thanks again, --=20 Sergio