From: Pedro Alves <palves@redhat.com>
To: "Tiago Stürmer Daitx" <tdaitx@linux.vnet.ibm.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix complex argument handling in ppc64 dummy function call
Date: Fri, 01 Mar 2013 21:24:00 -0000 [thread overview]
Message-ID: <51310E9C.8080505@redhat.com> (raw)
In-Reply-To: <20130301170811.EFEA2300943@igoo.rch.stglabs.ibm.com>
(not a real review, probably Ulrich would be
the best reviewer).
On 03/01/2013 05:08 PM, Tiago Stürmer Daitx wrote:
> + struct type *target_type;
> +
> + target_type = check_typedef (TYPE_TARGET_TYPE (type));
> + if (write_pass)
> + ppc64_sysv_abi_push_float (gdbarch, regcache, tdep,
While quickly skimming the patch I just noticed something wrong with
the indenting here.
> + target_type, val + i *
> + TYPE_LENGTH (target_type),
> + freg, greg, gparam);
> + freg += 2;
> + greg += 2;
> + gparam = align_up (gparam + TYPE_LENGTH (target_type),
> + tdep->wordsize);
> + }
--
Pedro Alves
next prev parent reply other threads:[~2013-03-01 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 18:30 Tiago Stürmer Daitx
2013-03-01 2:55 ` Sergio Durigan Junior
2013-03-01 17:50 ` Tiago Stürmer Daitx
2013-03-01 18:57 ` Sergio Durigan Junior
2013-03-01 20:07 ` Tiago Stürmer Daitx
2013-03-01 21:24 ` Pedro Alves [this message]
2013-03-01 23:42 ` Tiago Stürmer Daitx
2013-03-11 16:12 ` Ulrich Weigand
2013-04-01 4:15 ` Tiago Stürmer Daitx
2013-04-02 13:41 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51310E9C.8080505@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tdaitx@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox