From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24875 invoked by alias); 1 Mar 2013 21:24:26 -0000 Received: (qmail 24863 invoked by uid 22791); 1 Mar 2013 21:24:25 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 21:24:20 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r21LNu3j004211 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Mar 2013 16:23:57 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r21KP0bD014776; Fri, 1 Mar 2013 15:25:01 -0500 Message-ID: <51310E9C.8080505@redhat.com> Date: Fri, 01 Mar 2013 21:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Tiago_St=FCrmer_Daitx?= CC: Sergio Durigan Junior , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix complex argument handling in ppc64 dummy function call References: <20130301170811.EFEA2300943@igoo.rch.stglabs.ibm.com> In-Reply-To: <20130301170811.EFEA2300943@igoo.rch.stglabs.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00046.txt.bz2 (not a real review, probably Ulrich would be the best reviewer). On 03/01/2013 05:08 PM, Tiago Stürmer Daitx wrote: > + struct type *target_type; > + > + target_type = check_typedef (TYPE_TARGET_TYPE (type)); > + if (write_pass) > + ppc64_sysv_abi_push_float (gdbarch, regcache, tdep, While quickly skimming the patch I just noticed something wrong with the indenting here. > + target_type, val + i * > + TYPE_LENGTH (target_type), > + freg, greg, gparam); > + freg += 2; > + greg += 2; > + gparam = align_up (gparam + TYPE_LENGTH (target_type), > + tdep->wordsize); > + } -- Pedro Alves