Re: [PATCH] Fix complex argument handling in ppc64 dummy function call

["Tiago Stürmer Daitx" <tdaitx@linux.vnet.ibm.com>]

On Fri, 2013-03-01 at 20:25 +0000, Pedro Alves wrote:
> (not a real review, probably Ulrich would be
> the best reviewer).
> 
> On 03/01/2013 05:08 PM, Tiago Stürmer Daitx wrote:
> > +		  struct type *target_type;
> > +
> > +		  target_type = check_typedef (TYPE_TARGET_TYPE (type));
> > +                  if (write_pass)
> > +		    ppc64_sysv_abi_push_float (gdbarch, regcache, tdep,
> 
> While quickly skimming the patch I just noticed something wrong with
> the indenting here.
> 
> > +					       target_type, val + i *
> > +					       TYPE_LENGTH (target_type),
> > +					       freg, greg, gparam);
> > +                  freg += 2;
> > +                  greg += 2;
> > +                  gparam = align_up (gparam + TYPE_LENGTH (target_type),
> > +                                     tdep->wordsize);
> > +                }
> 
> 

Pedro, thanks for catching this. =)



And just in case it might help somebody else, this is what I did in vim
to show tabs and end-of-lines:

:set listchars=tab:»\ ,eol:¬,trail:¶
:set list

I picked those chars because I wanted them to look very differently from
everything else in the code. Hopefully I'll be able to quickly notice
and correct wrong indentations and spurious spaces at eol from now on.