From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16156 invoked by alias); 1 Mar 2013 23:42:20 -0000 Received: (qmail 16148 invoked by uid 22791); 1 Mar 2013 23:42:19 -0000 X-SWARE-Spam-Status: No, hits=-8.5 required=5.0 tests=BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Mar 2013 23:42:06 +0000 Received: from /spool/local by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Mar 2013 20:42:04 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp01.br.ibm.com (10.172.0.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 1 Mar 2013 20:42:03 -0300 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 5EFE2352005F for ; Fri, 1 Mar 2013 18:42:02 -0500 (EST) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r21Ne7Zn2514994 for ; Fri, 1 Mar 2013 20:40:07 -0300 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r21LfmWw026740 for ; Fri, 1 Mar 2013 18:41:49 -0300 Received: from [9.12.224.129] ([9.12.224.129]) by d24av04.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r21Lfkwg026683; Fri, 1 Mar 2013 18:41:47 -0300 Message-ID: <1362181318.11547.15.camel@localhost.localdomain> Subject: Re: [PATCH] Fix complex argument handling in ppc64 dummy function call From: Tiago =?ISO-8859-1?Q?St=FCrmer?= Daitx To: Pedro Alves Cc: gdb-patches@sourceware.org Date: Fri, 01 Mar 2013 23:42:00 -0000 In-Reply-To: <51310E9C.8080505@redhat.com> References: <20130301170811.EFEA2300943@igoo.rch.stglabs.ibm.com> <51310E9C.8080505@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13030123-1524-0000-0000-0000055CBC5F X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00047.txt.bz2 On Fri, 2013-03-01 at 20:25 +0000, Pedro Alves wrote: > (not a real review, probably Ulrich would be > the best reviewer). > > On 03/01/2013 05:08 PM, Tiago Stürmer Daitx wrote: > > + struct type *target_type; > > + > > + target_type = check_typedef (TYPE_TARGET_TYPE (type)); > > + if (write_pass) > > + ppc64_sysv_abi_push_float (gdbarch, regcache, tdep, > > While quickly skimming the patch I just noticed something wrong with > the indenting here. > > > + target_type, val + i * > > + TYPE_LENGTH (target_type), > > + freg, greg, gparam); > > + freg += 2; > > + greg += 2; > > + gparam = align_up (gparam + TYPE_LENGTH (target_type), > > + tdep->wordsize); > > + } > > Pedro, thanks for catching this. =) And just in case it might help somebody else, this is what I did in vim to show tabs and end-of-lines: :set listchars=tab:»\ ,eol:¬,trail:¶ :set list I picked those chars because I wanted them to look very differently from everything else in the code. Hopefully I'll be able to quickly notice and correct wrong indentations and spurious spaces at eol from now on.