From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org,
Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Forbid watchpoint on a constant value
Date: Tue, 15 Jun 2010 17:30:00 -0000 [thread overview]
Message-ID: <m3r5k8urum.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201006050150.08687.sergiodj@redhat.com> (Sergio Durigan Junior's message of "Sat, 5 Jun 2010 01:50:08 -0300")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> 2010-06-05 Jan Kratochvil <jan.kratochvil@redhat.com>
Sergio> Sergio Durigan Junior <sergiodj@redhat.com>
Sergio> * breakpoint.c: Include parser-defs.h.
Sergio> (watchpoint_exp_is_const): New function.
Sergio> (watch_command_1): Call watchpoint_exp_is_const to check
Sergio> if the expression is constant.
Looks pretty good.
Sergio> +static int watchpoint_exp_is_const (const struct expression *exp);
I don't think you should need this forward declaration.
Sergio> + gdb_test_no_output "set \$expr_breakpoint_number = \$bpnum"
Sergio> + gdb_test_no_output "delete \$expr_breakpoint_number"
I don't see why you can't just use "delete \$bpnum" here.
More importantly, because these commands are repeated, they should be
given distinguishing names.
This patch is ok with those changes. Thanks.
Tom
next prev parent reply other threads:[~2010-06-15 17:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 17:36 Sergio Durigan Junior
2010-05-18 17:49 ` Eli Zaretskii
2010-05-18 19:24 ` Sergio Durigan Junior
2010-05-18 23:08 ` Jan Kratochvil
2010-05-18 23:50 ` Sergio Durigan Junior
2010-05-19 20:26 ` Jan Kratochvil
2010-05-20 6:21 ` Sergio Durigan Junior
2010-05-20 15:50 ` Jan Kratochvil
2010-05-20 16:24 ` Sergio Durigan Junior
2010-05-20 17:03 ` Jan Kratochvil
2010-05-20 17:06 ` Sergio Durigan Junior
2010-05-27 21:54 ` Tom Tromey
2010-05-20 23:23 ` Joel Brobecker
2010-05-20 23:31 ` Sergio Durigan Junior
2010-05-20 23:55 ` Joel Brobecker
2010-05-21 0:09 ` Sergio Durigan Junior
2010-05-21 7:05 ` Eli Zaretskii
2010-05-21 8:44 ` Jan Kratochvil
2010-05-21 21:43 ` Sergio Durigan Junior
2010-05-21 22:20 ` Sergio Durigan Junior
2010-05-29 0:04 ` Joel Brobecker
2010-06-04 13:54 ` Jan Kratochvil
2010-06-04 16:49 ` Tom Tromey
2010-06-05 5:35 ` Sergio Durigan Junior
2010-06-05 14:38 ` Jan Kratochvil
2010-06-06 0:20 ` Sergio Durigan Junior
2010-06-15 17:30 ` Tom Tromey [this message]
2010-06-16 18:33 ` Sergio Durigan Junior
2010-06-16 18:36 ` Jan Kratochvil
2010-05-28 5:12 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5k8urum.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox