From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30970 invoked by alias); 15 Jun 2010 17:30:04 -0000 Received: (qmail 30908 invoked by uid 22791); 15 Jun 2010 17:30:02 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jun 2010 17:29:58 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FHThXV024221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Jun 2010 13:29:43 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5FHTgWG018032; Tue, 15 Jun 2010 13:29:42 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5FHTfL9005724; Tue, 15 Jun 2010 13:29:42 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 47884379863; Tue, 15 Jun 2010 11:29:39 -0600 (MDT) From: Tom Tromey To: Sergio Durigan Junior Cc: Joel Brobecker , gdb-patches@sourceware.org, Jan Kratochvil Subject: Re: [PATCH] Forbid watchpoint on a constant value References: <20100521070500.GA30452@host0.dyn.jankratochvil.net> <201005211912.39680.sergiodj@redhat.com> <20100528231122.GO3019@adacore.com> <201006050150.08687.sergiodj@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 15 Jun 2010 17:30:00 -0000 In-Reply-To: <201006050150.08687.sergiodj@redhat.com> (Sergio Durigan Junior's message of "Sat, 5 Jun 2010 01:50:08 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00343.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> 2010-06-05 Jan Kratochvil Sergio> Sergio Durigan Junior Sergio> * breakpoint.c: Include parser-defs.h. Sergio> (watchpoint_exp_is_const): New function. Sergio> (watch_command_1): Call watchpoint_exp_is_const to check Sergio> if the expression is constant. Looks pretty good. Sergio> +static int watchpoint_exp_is_const (const struct expression *exp); I don't think you should need this forward declaration. Sergio> + gdb_test_no_output "set \$expr_breakpoint_number = \$bpnum" Sergio> + gdb_test_no_output "delete \$expr_breakpoint_number" I don't see why you can't just use "delete \$bpnum" here. More importantly, because these commands are repeated, they should be given distinguishing names. This patch is ok with those changes. Thanks. Tom