Re: [PATCH] Forbid watchpoint on a constant value

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 19 May 2010 01:42:58 +0200, Sergio Durigan Junior wrote:
> > > --- /dev/null
> > > +++ b/gdb/testsuite/gdb.base/watch-notconst.c
> > > @@ -0,0 +1,23 @@
> > > +/* The original program corresponding to watch-notconst.S.
> > > +
> > > +   This program is not compiled; the .S version is used instead.
> > > +
> > > +   The purpose of this test is to see if GDB can still watch the
> > > +   variable `x' even when we compile the program using -O2
> > > +   optimization.  */
> > 
> > Missing FSF copyleft header.
> 
> Thanks.

But now your .S files .debug_line do not correspond to these .c files.


> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/watch-notconst.S

Figured now I see no reason why this file should be precompiled.  The only
sensitive testing is in the only function f() in watch-notconst2.S.
watch-notconst.* is just a glue to be able to run f().


> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/watch-notconst2.S
> +.LASF1:
> +	.string	"watch-notconst2.c"
> +.LASF2:
> +	.string	"/home/sergio/work/src/git/gdb-src/gdb/testsuite/gdb.base"

I would prefer some adjustment so that gdb and `objdump -dS' works on it.
But this problem may be present even in other testcases, just a nitpick.


Also when it is arch-dependent DWARF it should be IMO in gdb.dwarf2/ (or
possibly gdb.arch/).



Thanks,
Jan