From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4224 invoked by alias); 19 May 2010 19:43:32 -0000 Received: (qmail 4214 invoked by uid 22791); 19 May 2010 19:43:32 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 May 2010 19:43:27 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o4JJhQXl017459 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 May 2010 15:43:26 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o4JJhNtL004626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 19 May 2010 15:43:25 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o4JJhM2Q001151; Wed, 19 May 2010 21:43:22 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o4JJhMOx001144; Wed, 19 May 2010 21:43:22 +0200 Date: Wed, 19 May 2010 20:26:00 -0000 From: Jan Kratochvil To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Forbid watchpoint on a constant value Message-ID: <20100519194322.GA32728@host0.dyn.jankratochvil.net> References: <201005181418.24324.sergiodj@redhat.com> <20100518223106.GA12536@host0.dyn.jankratochvil.net> <201005182043.00433.sergiodj@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201005182043.00433.sergiodj@redhat.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00395.txt.bz2 On Wed, 19 May 2010 01:42:58 +0200, Sergio Durigan Junior wrote: > > > --- /dev/null > > > +++ b/gdb/testsuite/gdb.base/watch-notconst.c > > > @@ -0,0 +1,23 @@ > > > +/* The original program corresponding to watch-notconst.S. > > > + > > > + This program is not compiled; the .S version is used instead. > > > + > > > + The purpose of this test is to see if GDB can still watch the > > > + variable `x' even when we compile the program using -O2 > > > + optimization. */ > > > > Missing FSF copyleft header. > > Thanks. But now your .S files .debug_line do not correspond to these .c files. > --- /dev/null > +++ b/gdb/testsuite/gdb.base/watch-notconst.S Figured now I see no reason why this file should be precompiled. The only sensitive testing is in the only function f() in watch-notconst2.S. watch-notconst.* is just a glue to be able to run f(). > --- /dev/null > +++ b/gdb/testsuite/gdb.base/watch-notconst2.S > +.LASF1: > + .string "watch-notconst2.c" > +.LASF2: > + .string "/home/sergio/work/src/git/gdb-src/gdb/testsuite/gdb.base" I would prefer some adjustment so that gdb and `objdump -dS' works on it. But this problem may be present even in other testcases, just a nitpick. Also when it is arch-dependent DWARF it should be IMO in gdb.dwarf2/ (or possibly gdb.arch/). Thanks, Jan