* [patch] varobj regression by python
@ 2009-05-30 12:52 Jan Kratochvil
2009-06-04 17:46 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kratochvil @ 2009-05-30 12:52 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
Hi,
the recent Python check-in
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/varobj.c.diff?cvsroot=src&r1=1.130&r2=1.131
regressed a new testcase
gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: out of scope now, not changed
checked-in recently by
http://sourceware.org/ml/gdb-patches/2009-05/msg00343.html
.
Thanks,
Jan
2009-05-29 Jan Kratochvil <jan.kratochvil@redhat.com>
* varobj.c (varobj_update): Fix out of scope varobjs to not to change.
--- gdb/varobj.c 28 May 2009 01:09:19 -0000 1.131
+++ gdb/varobj.c 29 May 2009 17:41:59 -0000
@@ -1539,7 +1539,8 @@ VEC(varobj_update_result) *varobj_update
if (r.status == VAROBJ_NOT_IN_SCOPE)
{
- VEC_safe_push (varobj_update_result, result, &r);
+ if (r.type_changed || r.changed)
+ VEC_safe_push (varobj_update_result, result, &r);
return result;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] varobj regression by python
2009-05-30 12:52 [patch] varobj regression by python Jan Kratochvil
@ 2009-06-04 17:46 ` Tom Tromey
2009-06-04 21:57 ` Jan Kratochvil
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2009-06-04 17:46 UTC (permalink / raw)
To: Jan Kratochvil; +Cc: gdb-patches
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> 2009-05-29 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> * varobj.c (varobj_update): Fix out of scope varobjs to not to change.
This is ok. Thanks.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] varobj regression by python
2009-06-04 17:46 ` Tom Tromey
@ 2009-06-04 21:57 ` Jan Kratochvil
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kratochvil @ 2009-06-04 21:57 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On Thu, 04 Jun 2009 19:46:28 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> 2009-05-29 Jan Kratochvil <jan.kratochvil@redhat.com>
> Jan> * varobj.c (varobj_update): Fix out of scope varobjs to not to change.
>
> This is ok. Thanks.
Checked-in:
http://sourceware.org/ml/gdb-cvs/2009-06/msg00019.html
Thanks,
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-04 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-30 12:52 [patch] varobj regression by python Jan Kratochvil
2009-06-04 17:46 ` Tom Tromey
2009-06-04 21:57 ` Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox