From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20433 invoked by alias); 30 May 2009 12:52:30 -0000 Received: (qmail 20423 invoked by uid 22791); 30 May 2009 12:52:30 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 30 May 2009 12:52:24 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4UCqMoW001407 for ; Sat, 30 May 2009 08:52:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4UCqLsL020750; Sat, 30 May 2009 08:52:22 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4UCqJ4Z012745; Sat, 30 May 2009 08:52:21 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n4UCqI9f014308; Sat, 30 May 2009 14:52:18 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id n4UCqHFq014303; Sat, 30 May 2009 14:52:17 +0200 Date: Sat, 30 May 2009 12:52:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [patch] varobj regression by python Message-ID: <20090530125217.GA14061@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00648.txt.bz2 Hi, the recent Python check-in http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/varobj.c.diff?cvsroot=src&r1=1.130&r2=1.131 regressed a new testcase gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: out of scope now, not changed checked-in recently by http://sourceware.org/ml/gdb-patches/2009-05/msg00343.html . Thanks, Jan 2009-05-29 Jan Kratochvil * varobj.c (varobj_update): Fix out of scope varobjs to not to change. --- gdb/varobj.c 28 May 2009 01:09:19 -0000 1.131 +++ gdb/varobj.c 29 May 2009 17:41:59 -0000 @@ -1539,7 +1539,8 @@ VEC(varobj_update_result) *varobj_update if (r.status == VAROBJ_NOT_IN_SCOPE) { - VEC_safe_push (varobj_update_result, result, &r); + if (r.type_changed || r.changed) + VEC_safe_push (varobj_update_result, result, &r); return result; }