Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [patch] varobj regression by python
Date: Sat, 30 May 2009 12:52:00 -0000	[thread overview]
Message-ID: <20090530125217.GA14061@host0.dyn.jankratochvil.net> (raw)

Hi,

the recent Python check-in
	http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/varobj.c.diff?cvsroot=src&r1=1.130&r2=1.131
regressed a new testcase
	gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: out of scope now, not changed
checked-in recently by
	http://sourceware.org/ml/gdb-patches/2009-05/msg00343.html
.

Thanks,
Jan


2009-05-29  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* varobj.c (varobj_update): Fix out of scope varobjs to not to change.

--- gdb/varobj.c	28 May 2009 01:09:19 -0000	1.131
+++ gdb/varobj.c	29 May 2009 17:41:59 -0000
@@ -1539,7 +1539,8 @@ VEC(varobj_update_result) *varobj_update
 
       if (r.status == VAROBJ_NOT_IN_SCOPE)
 	{
-	  VEC_safe_push (varobj_update_result, result, &r);
+	  if (r.type_changed || r.changed)
+	    VEC_safe_push (varobj_update_result, result, &r);
 	  return result;
 	}
             


             reply	other threads:[~2009-05-30 12:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-30 12:52 Jan Kratochvil [this message]
2009-06-04 17:46 ` Tom Tromey
2009-06-04 21:57   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090530125217.GA14061@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox