From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix separate-debug with non-unique section names (PR 11409)
Date: Thu, 25 Mar 2010 20:00:00 -0000 [thread overview]
Message-ID: <m3ocicdve7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100325145913.GA26968@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 25 Mar 2010 15:59:13 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Tom> Can we stably sort the sections by name, using the initial index as
Tom> a secondary key?
Jan> OK, attached.
Thanks... for future reference, and for anybody following along, it is
also ok to push back on questions like that if you think they are bad
ideas. Like we discussed on irc, I couldn't really tell from this reply
what you thought of it.
Jan> 2010-03-25 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> * symfile.c (build_section_addr_info_from_bfd): New.
Jan> (build_section_addr_info_from_objfile): Base it on
Jan> build_section_addr_info_from_bfd.
Jan> (addrs_section_compar, addrs_section_sort): New.
Jan> (addr_info_make_relative): New variables my_cleanup, abfd_addrs,
Jan> addrs_sorted, abfd_addrs_sorted and addrs_to_abfd_addrs. Build
Jan> addrs_to_abfd_addrs. Use it for recalculating ADDRS.
Jan> + /* SECTINDEX is underfined iff ADDR is zero. */
A small typo: s/underfined/undefined/
This patch looks good to me. It is ok.
Tom
next prev parent reply other threads:[~2010-03-25 20:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 20:57 Jan Kratochvil
2010-03-24 19:02 ` Tom Tromey
2010-03-24 19:23 ` Mark Kettenis
2010-03-24 20:09 ` Jan Kratochvil
2010-03-24 20:18 ` Daniel Jacobowitz
2010-03-24 20:33 ` Jan Kratochvil
2010-03-24 20:37 ` Tom Tromey
2010-03-25 14:59 ` Jan Kratochvil
2010-03-25 20:00 ` Tom Tromey [this message]
2010-03-25 20:38 ` Jan Kratochvil
2010-04-21 20:03 ` Tom Tromey
2010-04-22 23:22 ` Jan Kratochvil
2010-03-24 20:43 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ocicdve7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox