From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30539 invoked by alias); 25 Mar 2010 20:00:26 -0000 Received: (qmail 30528 invoked by uid 22791); 25 Mar 2010 20:00:25 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Mar 2010 20:00:20 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2PK0IsH014353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Mar 2010 16:00:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2PK0Hvo006796; Thu, 25 Mar 2010 16:00:17 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2PK0GAN011938; Thu, 25 Mar 2010 16:00:16 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 43D9D37822D; Thu, 25 Mar 2010 14:00:16 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix separate-debug with non-unique section names (PR 11409) References: <20100323205655.GA12124@host0.dyn.jankratochvil.net> <20100324200943.GA12225@host0.dyn.jankratochvil.net> <20100324201825.GA31992@caradoc.them.org> <20100324203252.GA17319@host0.dyn.jankratochvil.net> <20100325145913.GA26968@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Thu, 25 Mar 2010 20:00:00 -0000 In-Reply-To: <20100325145913.GA26968@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Thu, 25 Mar 2010 15:59:13 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00858.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Tom> Can we stably sort the sections by name, using the initial index as Tom> a secondary key? Jan> OK, attached. Thanks... for future reference, and for anybody following along, it is also ok to push back on questions like that if you think they are bad ideas. Like we discussed on irc, I couldn't really tell from this reply what you thought of it. Jan> 2010-03-25 Jan Kratochvil Jan> * symfile.c (build_section_addr_info_from_bfd): New. Jan> (build_section_addr_info_from_objfile): Base it on Jan> build_section_addr_info_from_bfd. Jan> (addrs_section_compar, addrs_section_sort): New. Jan> (addr_info_make_relative): New variables my_cleanup, abfd_addrs, Jan> addrs_sorted, abfd_addrs_sorted and addrs_to_abfd_addrs. Build Jan> addrs_to_abfd_addrs. Use it for recalculating ADDRS. Jan> + /* SECTINDEX is underfined iff ADDR is zero. */ A small typo: s/underfined/undefined/ This patch looks good to me. It is ok. Tom