From: Daniel Jacobowitz <dan@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix separate-debug with non-unique section names (PR 11409)
Date: Wed, 24 Mar 2010 20:18:00 -0000 [thread overview]
Message-ID: <20100324201825.GA31992@caradoc.them.org> (raw)
In-Reply-To: <20100324200943.GA12225@host0.dyn.jankratochvil.net>
On Wed, Mar 24, 2010 at 09:09:43PM +0100, Jan Kratochvil wrote:
> While the algorithm could be much more clever - if we ever need to resync at
> the point of non-unique section names the files are too different it makes no
> sence to try to match them by addr_info_make_relative at all.
What if we assume that in a valid separate debug file, the only
sections that will be different will have been totally stripped from
either the before or after file?
IOW:
i = 0 // index in main file
j = 0 // index in separate file
for each section in main file:
if (section names match)
good
else if (section i's name is not present in separate file)
i++, continue
else if (section j's name is not present in separate file)
j++, continue
else
complain that the two files do not match
?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-03-24 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 20:57 Jan Kratochvil
2010-03-24 19:02 ` Tom Tromey
2010-03-24 19:23 ` Mark Kettenis
2010-03-24 20:09 ` Jan Kratochvil
2010-03-24 20:18 ` Daniel Jacobowitz [this message]
2010-03-24 20:33 ` Jan Kratochvil
2010-03-24 20:37 ` Tom Tromey
2010-03-25 14:59 ` Jan Kratochvil
2010-03-25 20:00 ` Tom Tromey
2010-03-25 20:38 ` Jan Kratochvil
2010-04-21 20:03 ` Tom Tromey
2010-04-22 23:22 ` Jan Kratochvil
2010-03-24 20:43 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324201825.GA31992@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox