Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix separate-debug with non-unique section names (PR    11409)
Date: Thu, 25 Mar 2010 20:38:00 -0000	[thread overview]
Message-ID: <20100325203846.GA27212@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <m3ocicdve7.fsf@fleche.redhat.com>

On Thu, 25 Mar 2010 21:00:16 +0100, Tom Tromey wrote:
> Thanks... for future reference, and for anybody following along, it is
> also ok to push back on questions like that if you think they are bad
> ideas.  Like we discussed on irc, I couldn't really tell from this reply
> what you thought of it.

I have to admit I do not believe there would ever be seen any real world
functionality difference between the first 14-liner and this 126-liner.

But I agree this second/checked-in patch is a more complete/safe solution for
the problem.  So if there have popped up concerns about the first patch and
GDB maintainers agree to accept the larger codebase of the more complete/safe
solution the technical cost of coding such implementation I find more
appropriate than arguing about it.


> A small typo: s/underfined/undefined/

Fixed.

> This patch looks good to me.  It is ok.

Checked-in:
	http://sourceware.org/ml/gdb-cvs/2010-03/msg00241.html


Now the question remains what to use for gdb_7_1-branch as it fixes
a regression (by me) from gdb-7.0 as described in the first mail:
	http://sourceware.org/ml/gdb-patches/2010-03/msg00799.html

I would even suggest the first simple variant of the patch from that mail.


Thanks,
Jan


  reply	other threads:[~2010-03-25 20:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 20:57 Jan Kratochvil
2010-03-24 19:02 ` Tom Tromey
2010-03-24 19:23   ` Mark Kettenis
2010-03-24 20:09   ` Jan Kratochvil
2010-03-24 20:18     ` Daniel Jacobowitz
2010-03-24 20:33       ` Jan Kratochvil
2010-03-24 20:37         ` Tom Tromey
2010-03-25 14:59           ` Jan Kratochvil
2010-03-25 20:00             ` Tom Tromey
2010-03-25 20:38               ` Jan Kratochvil [this message]
2010-04-21 20:03                 ` Tom Tromey
2010-04-22 23:22                   ` Jan Kratochvil
2010-03-24 20:43         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100325203846.GA27212@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox