From: Tom Tromey <tromey@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event
Date: Mon, 25 Apr 2011 18:19:00 -0000 [thread overview]
Message-ID: <m3oc3uurbw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <BANLkTikm-GqD0fubzfaoRUZCEz=JDy9GWg@mail.gmail.com> (Kevin Pouget's message of "Thu, 21 Apr 2011 05:18:39 -0400")
>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:
Kevin> Following Tom's advise
Kevin> (http://sourceware.org/ml/gdb/2011-04/msg00116.html), here is a patch
Kevin> which hooks the inferior to the `exited' event object
Kevin> let me know what you think about it
It looks pretty good, but I think it needs a couple small changes.
Kevin> + if (evpy_add_attribute (exited_event,
Kevin> + "inferior",
Kevin> + inferior_to_inferior_object (inf)) < 0)
Kevin> + goto fail;
This does not account for the possibility that
inferior_to_inferior_object could fail. I think there has
to be a temporary object that is explicitly checked against NULL.
Kevin> +gdb_test "continue" ".*event type: continue.*
Kevin> +.*event type: exit.*
Kevin> +.*exit code: 12.*
Kevin> +.*exit inf: 2.*"
Pass a test name to gdb_test.
Tom
next prev parent reply other threads:[~2011-04-25 18:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 9:19 Kevin Pouget
2011-04-21 10:01 ` Eli Zaretskii
2011-04-25 18:19 ` Tom Tromey [this message]
2011-04-26 8:24 ` Kevin Pouget
2011-08-31 14:34 ` Kevin Pouget
2011-08-31 14:46 ` Eli Zaretskii
2011-08-31 14:58 ` Kevin Pouget
2011-08-31 17:27 ` Eli Zaretskii
2011-08-31 17:53 ` Tom Tromey
2011-08-31 17:59 ` Eli Zaretskii
2011-09-01 9:18 ` Kevin Pouget
2011-09-01 8:45 ` Kevin Pouget
2011-09-01 10:12 ` Eli Zaretskii
2011-09-01 11:29 ` Kevin Pouget
2011-09-15 12:49 ` Kevin Pouget
2011-09-15 13:58 ` Eli Zaretskii
2011-09-15 14:19 ` Paul_Koning
2011-09-15 15:27 ` Kevin Pouget
2011-09-15 15:42 ` Eli Zaretskii
2011-08-31 15:50 ` Tom Tromey
2011-09-19 10:37 ` Kevin Pouget
2011-09-19 10:41 ` Eli Zaretskii
2011-10-03 16:38 ` Tom Tromey
2011-10-04 8:05 ` Kevin Pouget
2011-10-05 12:15 ` Regression (or a new FAIL?): gdb.python/py-events.exp [Re: [PATCH] PR/12691 Add the inferior to Python exited event] Jan Kratochvil
2011-10-05 12:37 ` Kevin Pouget
2011-10-05 14:16 ` Jan Kratochvil
2011-10-05 14:56 ` Kevin Pouget
2011-10-09 18:17 ` [patch] gdb.python/py-events.exp: Disable multi-inferior for gdbserver [Re: Regression (or a new FAIL?): gdb.python/py-events.exp] Jan Kratochvil
2011-10-26 15:07 ` Pedro Alves
2011-10-27 10:31 ` [patch] Forbid "run" etc. for use_gdb_stub targets [Re: [patch] gdb.python/py-events.exp: Disable multi-inferior for gdbserver] Jan Kratochvil
2011-10-27 18:26 ` Pedro Alves
2011-10-28 17:40 ` [commit test fixes] " Jan Kratochvil
2011-10-28 17:42 ` Jan Kratochvil
2011-10-28 18:32 ` Pedro Alves
2011-10-29 19:55 ` Jan Kratochvil
2011-12-03 18:37 ` ping: Re: [patch] Forbid "run" etc. for use_gdb_stub targets Jan Kratochvil
2011-12-03 19:15 ` Pedro Alves
2011-12-03 20:22 ` [commit] " Jan Kratochvil
2011-12-04 1:02 ` ping: " Doug Evans
2011-12-04 1:30 ` Jan Kratochvil
2011-12-04 2:55 ` Doug Evans
2011-12-05 20:25 ` Jan Kratochvil
2011-12-05 21:44 ` Doug Evans
2011-12-05 23:36 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3oc3uurbw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevin.pouget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox