From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32558 invoked by alias); 25 Apr 2011 18:19:37 -0000 Received: (qmail 32546 invoked by uid 22791); 25 Apr 2011 18:19:36 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Apr 2011 18:19:18 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3PIJHZ0017993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 Apr 2011 14:19:17 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3PIJG63015322; Mon, 25 Apr 2011 14:19:17 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3PIJGEV024507; Mon, 25 Apr 2011 14:19:16 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 1F5383781C7; Mon, 25 Apr 2011 12:19:16 -0600 (MDT) From: Tom Tromey To: Kevin Pouget Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] PR/12691 Add the inferior to Python exited event References: Date: Mon, 25 Apr 2011 18:19:00 -0000 In-Reply-To: (Kevin Pouget's message of "Thu, 21 Apr 2011 05:18:39 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00449.txt.bz2 >>>>> "Kevin" == Kevin Pouget writes: Kevin> Following Tom's advise Kevin> (http://sourceware.org/ml/gdb/2011-04/msg00116.html), here is a patch Kevin> which hooks the inferior to the `exited' event object Kevin> let me know what you think about it It looks pretty good, but I think it needs a couple small changes. Kevin> + if (evpy_add_attribute (exited_event, Kevin> + "inferior", Kevin> + inferior_to_inferior_object (inf)) < 0) Kevin> + goto fail; This does not account for the possibility that inferior_to_inferior_object could fail. I think there has to be a temporary object that is explicitly checked against NULL. Kevin> +gdb_test "continue" ".*event type: continue.* Kevin> +.*event type: exit.* Kevin> +.*exit code: 12.* Kevin> +.*exit inf: 2.*" Pass a test name to gdb_test. Tom