From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: RFA: fix PR 1535
Date: Thu, 14 Aug 2008 18:00:00 -0000 [thread overview]
Message-ID: <m3myjf32ao.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20080814174814.GB15804@caradoc.them.org> (Daniel Jacobowitz's message of "Thu\, 14 Aug 2008 13\:48\:14 -0400")
>>>>> "Daniel" == Daniel Jacobowitz <drow@false.org> writes:
Daniel> Something like this: add_catch_command which takes normal
Daniel> add_cmd-like arguments and adds the command to both catch and
Daniel> tcatch.
No problem, I'll do this.
The thing is, we still need two versions of each function, because
AFAIK there is no way to pass a bit of "user data" along with a
command callback. This is a minor inconvenience of course -- though I
seem to run into it quite a bit.
Daniel> A single, manually written "catch_unimplemented" for the
Daniel> unimplemented commands - or just remove them, what value do
Daniel> they add?
I did not want to change this at all, basically to keep the patch
focused on one thing. But I agree, these non-functioning commands are
pointless. I'll go ahead and remove them.
Tom
next prev parent reply other threads:[~2008-08-14 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 18:19 Tom Tromey
2008-08-12 21:18 ` Tom Tromey
2008-08-14 17:49 ` Daniel Jacobowitz
2008-08-14 18:00 ` Tom Tromey [this message]
2008-08-14 18:15 ` Tom Tromey
2008-08-14 23:24 ` Tom Tromey
2008-08-15 4:20 ` Daniel Jacobowitz
2008-08-15 8:44 ` Andreas Schwab
2008-08-17 17:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3myjf32ao.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox