From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 730 invoked by alias); 14 Aug 2008 18:00:39 -0000 Received: (qmail 584 invoked by uid 22791); 14 Aug 2008 18:00:34 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Aug 2008 17:59:59 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m7EHxwOG010815 for ; Thu, 14 Aug 2008 13:59:58 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7EHxv1g005967; Thu, 14 Aug 2008 13:59:57 -0400 Received: from opsy.redhat.com (vpn-10-34.bos.redhat.com [10.16.10.34]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m7EHxtxR007650; Thu, 14 Aug 2008 13:59:57 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 32B14508578; Thu, 14 Aug 2008 12:00:00 -0600 (MDT) To: gdb-patches@sourceware.org Subject: Re: RFA: fix PR 1535 References: <20080814174814.GB15804@caradoc.them.org> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Thu, 14 Aug 2008 18:00:00 -0000 In-Reply-To: <20080814174814.GB15804@caradoc.them.org> (Daniel Jacobowitz's message of "Thu\, 14 Aug 2008 13\:48\:14 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00374.txt.bz2 >>>>> "Daniel" == Daniel Jacobowitz writes: Daniel> Something like this: add_catch_command which takes normal Daniel> add_cmd-like arguments and adds the command to both catch and Daniel> tcatch. No problem, I'll do this. The thing is, we still need two versions of each function, because AFAIK there is no way to pass a bit of "user data" along with a command callback. This is a minor inconvenience of course -- though I seem to run into it quite a bit. Daniel> A single, manually written "catch_unimplemented" for the Daniel> unimplemented commands - or just remove them, what value do Daniel> they add? I did not want to change this at all, basically to keep the patch focused on one thing. But I agree, these non-functioning commands are pointless. I'll go ahead and remove them. Tom