From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix PR 1535
Date: Fri, 15 Aug 2008 04:20:00 -0000 [thread overview]
Message-ID: <20080815042002.GC16436@caradoc.them.org> (raw)
In-Reply-To: <m3vdy318qd.fsf@fleche.redhat.com>
On Thu, Aug 14, 2008 at 05:23:54PM -0600, Tom Tromey wrote:
> How pedantically C is gdb? Here I cast some small integers to
> 'void*'. Alternatively I could turn the "context" into a union, or
> make some globals.
Go through uintptr_t, please. I've made stdint.h always available and that
will be the right size; if you go int -> void * you will break
x86_64. Well, you tested x86_64. But I'm not sure why you didn't get
a warning for (void *) 1.
> Also, I notice that hardly anything else uses the 'sfunc' code. Is
> the intent to restrict this just to 'set' functions? IOW, is this an
> abuse?
I dont know, but it looks entirely reasonable to me. Patch is OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-08-15 4:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 18:19 Tom Tromey
2008-08-12 21:18 ` Tom Tromey
2008-08-14 17:49 ` Daniel Jacobowitz
2008-08-14 18:00 ` Tom Tromey
2008-08-14 18:15 ` Tom Tromey
2008-08-14 23:24 ` Tom Tromey
2008-08-15 4:20 ` Daniel Jacobowitz [this message]
2008-08-15 8:44 ` Andreas Schwab
2008-08-17 17:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815042002.GC16436@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox