Re: RFA: fix PR 1535

[Daniel Jacobowitz <drow@false.org>]

On Tue, Aug 12, 2008 at 03:17:58PM -0600, Tom Tromey wrote:
> >>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
> 
> Tom> This patch fixes PR 1535.
> Tom> The bug here is that CLI tab completion does not work for "catch"
> Tom> commands.
> 
> After sending this I noticed a gettext snafu in the
> DEFINE_UNIMPLEMENTED macro -- stringization can't reasonably work
> here.
> 
> The fix is to change the error call to use %s instead.
> 
> I ran 'make gdb.pot' and looked at the result to verify that this
> change worked.

Just my taste, but I think this is pretty ugly.  Manually expanded
tables wouldn't be any better.  I think it's not as much extra typing
as you'd think to do it all without the tables.

Something like this: add_catch_command which takes normal add_cmd-like
arguments and adds the command to both catch and tcatch.  A single,
manually written "catch_unimplemented" for the unimplemented commands
- or just remove them, what value do they add?  And the other
functions are pretty simple.  Most of the bulk of TABLE is the
docstrings.

In other words, make it as much like other commands as possible.

WDYT?

-- 
Daniel Jacobowitz
CodeSourcery