From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26629 invoked by alias); 14 Aug 2008 17:49:07 -0000 Received: (qmail 26614 invoked by uid 22791); 14 Aug 2008 17:49:04 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Aug 2008 17:48:17 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A09D3983B4; Thu, 14 Aug 2008 17:48:15 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 768A198243; Thu, 14 Aug 2008 17:48:15 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KTgvm-0004C2-Ka; Thu, 14 Aug 2008 13:48:14 -0400 Date: Thu, 14 Aug 2008 17:49:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: fix PR 1535 Message-ID: <20080814174814.GB15804@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00369.txt.bz2 On Tue, Aug 12, 2008 at 03:17:58PM -0600, Tom Tromey wrote: > >>>>> "Tom" == Tom Tromey writes: > > Tom> This patch fixes PR 1535. > Tom> The bug here is that CLI tab completion does not work for "catch" > Tom> commands. > > After sending this I noticed a gettext snafu in the > DEFINE_UNIMPLEMENTED macro -- stringization can't reasonably work > here. > > The fix is to change the error call to use %s instead. > > I ran 'make gdb.pot' and looked at the result to verify that this > change worked. Just my taste, but I think this is pretty ugly. Manually expanded tables wouldn't be any better. I think it's not as much extra typing as you'd think to do it all without the tables. Something like this: add_catch_command which takes normal add_cmd-like arguments and adds the command to both catch and tcatch. A single, manually written "catch_unimplemented" for the unimplemented commands - or just remove them, what value do they add? And the other functions are pretty simple. Most of the bulk of TABLE is the docstrings. In other words, make it as much like other commands as possible. WDYT? -- Daniel Jacobowitz CodeSourcery