From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] breakpoint.c, create_breakpoint, document that the case statement falls through.
Date: Thu, 03 Mar 2011 17:45:00 -0000 [thread overview]
Message-ID: <m3lj0wxfn2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4D6FCBB1.9040507@vmware.com> (Michael Snyder's message of "Thu, 03 Mar 2011 09:11:13 -0800")
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> No, honest, it *does* fall through!
Michael> I had to use a printf statement to convince myself. ;-)
Michael> When the user answers "yes" to the query, it falls through.
Yeah. Your patch is correct, or at least correct-enough.
Adding a "break" would also be correct, because sals.nelts is never 0 at
the end of this case.
Tom
next prev parent reply other threads:[~2011-03-03 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 0:42 Michael Snyder
2011-03-03 4:27 ` Joel Brobecker
2011-03-03 9:55 ` Pedro Alves
2011-03-03 17:11 ` Michael Snyder
2011-03-03 17:45 ` Tom Tromey [this message]
2011-03-04 18:58 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lj0wxfn2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox