Re: [RFA] breakpoint.c, create_breakpoint, document that the case statement falls through.

[Michael Snyder <msnyder@vmware.com>]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> No, honest, it *does* fall through!
> Michael> I had to use a printf statement to convince myself.   ;-)
> Michael> When the user answers "yes" to the query, it falls through.
> 
> Yeah.  Your patch is correct, or at least correct-enough.
> Adding a "break" would also be correct, because sals.nelts is never 0 at
> the end of this case.
> 
> Tom

OK then, I'd rather break than fall through.
Committed as attached.


[-- Attachment #2: break10.txt --]
[-- Type: text/plain, Size: 570 bytes --]

2011-03-04  Michael Snyder  <msnyder@vmware.com>

	* breakpoint.c (create_breakpoint): Add missing break statement.

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.546
diff -u -p -u -p -r1.546 breakpoint.c
--- breakpoint.c	1 Mar 2011 02:16:56 -0000	1.546
+++ breakpoint.c	4 Mar 2011 18:57:27 -0000
@@ -7843,6 +7843,7 @@ create_breakpoint (struct gdbarch *gdbar
 	default:
 	  throw_exception (e);
 	}
+      break;
     default:
       if (!sals.nelts)
 	return 0;